Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eventing-rabbitmq maintainers #1409

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Update eventing-rabbitmq maintainers #1409

merged 2 commits into from
Aug 2, 2023

Conversation

dolfolife
Copy link
Member

Add Eventing team at VMware to the RabbitMQ Eventing project

@knative-prow knative-prow bot requested review from dsimansk and psschwei July 31, 2023 17:23
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 31, 2023
psschwei
psschwei requested changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to update peribolos/knative-sandbox.yaml and then run ./hack/update-codegen.sh to propagate your changes to the alias files

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 31, 2023
@psschwei
Copy link
Contributor

/assign @pierDipi
(assuming this should get sign-off from Eventing... )

@dolfolife
Copy link
Member Author

more context: I have been working with @gabo1208 on the RabbitMQ broker and source and the team needs access to approve changes in the eventing-rabbitmq repo

@dprotaso
Copy link
Member

/lgtm
/approve
/hold for @pierDipi

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2023
@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 31, 2023
@dprotaso dprotaso changed the title Update knative-sandbox-OWNERS_ALIASES Update eventing-rabbitmq maintainers Jul 31, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dolfolife, dprotaso, gabo1208

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Rodolfo Sanchez and others added 2 commits August 2, 2023 09:57
@dolfolife
Update knative-sandbox-OWNERS_ALIASES
2876975 
Add Eventing team at VMware to the RabbitMQ Eventing project
@dolfolife
add memebers of the VMware team to the RabbitMQ approver's list
0d46e42 
Signed-off-by: Rodolfo Sanchez <[email protected]>
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2023
@dprotaso
Copy link
Member

dprotaso commented Aug 2, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2023
@dprotaso
Copy link
Member

dprotaso commented Aug 2, 2023

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2023
@knative-prow knative-prow bot merged commit f71d93b into knative:main Aug 2, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psschwei psschwei psschwei requested changes

@gabo1208 gabo1208 gabo1208 approved these changes

@dsimansk dsimansk Awaiting requested review from dsimansk

Assignees

@dprotaso dprotaso

@gabo1208 gabo1208

@pierDipi pierDipi

@psschwei psschwei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dolfolife @psschwei @dprotaso @gabo1208 @pierDipi