Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gauron99 func reviewer #1405

Merged
merged 1 commit into from
Jul 26, 2023
Merged

gauron99 func reviewer #1405

merged 1 commit into from
Jul 26, 2023

Conversation

gauron99
Copy link
Contributor

Changes

going to be working on functions -> add me as a func reviewer to assign myself to issues

@knative-prow knative-prow bot requested review from dprotaso and psschwei July 25, 2023 14:39
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 25, 2023
@gauron99 gauron99 changed the title func rev gauron99 func reviewer Jul 25, 2023
@psschwei
Copy link
Contributor

/assign @lance @salaboy

lance
lance reviewed Jul 26, 2023
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, lance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2023
@knative-prow knative-prow bot merged commit f0009d7 into knative:main Jul 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance lance lance left review comments

@dprotaso dprotaso Awaiting requested review from dprotaso

@psschwei psschwei Awaiting requested review from psschwei

Assignees

@lance lance

@salaboy salaboy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gauron99 @psschwei @lance @salaboy