Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding dan-j as knative-sandbox member #1397

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

dan-j
Copy link
Contributor

@dan-j dan-j commented Jul 12, 2023

Changes

  • Adding myself, @dan-j, as a member of the knative-sandbox org.

Reasoning

I have contributed NATS JetStream support to the eventing-natss repo, and would like to continue maintenance in the long term.

@knative-prow knative-prow bot requested review from dsimansk and psschwei July 12, 2023 12:35
@knative-prow
Copy link

knative-prow bot commented Jul 12, 2023

Welcome @dan-j! It looks like this is your first PR to knative/community 🎉

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 12, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 12, 2023

Hi @dan-j. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 12, 2023
@dprotaso
Copy link
Member

/ok-to-test

You'll need to run ./hack/update-codegen.sh script

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 12, 2023
@dprotaso
Copy link
Member

Actually maybe not

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dan-j, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2023
@knative-prow knative-prow bot merged commit c50535d into knative:main Jul 12, 2023
2 checks passed
@dan-j dan-j deleted the add-dan-j-member branch July 26, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants