Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zbynek stepping down from TOC #1395

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Zbynek stepping down from TOC #1395

merged 1 commit into from
Aug 8, 2023

Conversation

zroubalik
Copy link
Contributor

Changes

  • Zbynek moved off TOC

@knative-prow knative-prow bot requested review from dprotaso and nainaz July 10, 2023 10:58
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 10, 2023
zroubalik
zroubalik commented Jul 10, 2023
View reviewed changes
Copy link
Contributor Author

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

I will need to hand over admin rights to this repo:
https://github.com/knative-sandbox/eventing-autoscaler-keda

https://github.com/knative/community/blob/06851c4dc6983ff2e005ed43c180cfacc75e708d/peribolos/knative-sandbox-OWNERS_ALIASES#L21C1-L22

community/peribolos/knative-sandbox.yaml

Line 857 in 06851c4

- zroubalik

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2023
@zroubalik
Copy link
Contributor Author

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2023
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2023
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2023
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 3, 2023
@zroubalik
Zbynek stepping down from TOC
757d748 
Signed-off-by: Zbynek Roubalik <[email protected]>
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2023
@rhuss
Copy link
Contributor

rhuss commented Aug 4, 2023

@zroubalik not so easy to get rid of us :-P (just kidding ...)

@zroubalik
Copy link
Contributor Author

@zroubalik not so easy to get rid of us :-P (just kidding ...)

🤷‍♂️ 😄

@dsimansk
Copy link
Contributor

dsimansk commented Aug 7, 2023

/assign @knative/steering-committee

@lance
Copy link
Member

lance commented Aug 7, 2023

/lgtm

Good luck in your new adventures, @zroubalik!

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2023
@dprotaso
Copy link
Member

dprotaso commented Aug 8, 2023

@knative/steering-committee needs to approve this

@lance
Copy link
Member

lance commented Aug 8, 2023

/approve

@knative-prow
Copy link

knative-prow bot commented Aug 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2023
@knative-prow knative-prow bot merged commit 8e294ca into knative:main Aug 8, 2023
6 checks passed
@ReToCode ReToCode mentioned this pull request Dec 1, 2023
Merged
@aliok aliok mentioned this pull request Jan 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprotaso dprotaso Awaiting requested review from dprotaso

@nainaz nainaz Awaiting requested review from nainaz

Assignees

@lance lance

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zroubalik @rhuss @dsimansk @lance @dprotaso @knative-prow-robot