Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in creydr username #1389

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Fix typo in creydr username #1389

merged 1 commit into from
Jun 28, 2023

Conversation

creydr
Copy link
Member

@creydr creydr commented Jun 28, 2023

In #1387 my username was misspelled at some places. This PR addressed it and fixes the typo.

@knative-prow knative-prow bot requested review from krsna-m and zroubalik June 28, 2023 07:02
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 28, 2023
@creydr
Copy link
Member Author

creydr commented Jun 28, 2023

/assign @dprotaso @kvmware @zroubalik

@creydr
Copy link
Member Author

creydr commented Jun 28, 2023

/cc @skonto

@knative-prow knative-prow bot requested a review from skonto June 28, 2023 07:06
@creydr creydr mentioned this pull request Jun 28, 2023
Merged
@skonto
Copy link
Contributor

skonto commented Jun 28, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2023
@skonto
Copy link
Contributor

skonto commented Jun 28, 2023

Sorry for that, initially I spotted it and I thought I fixed it everywhere but obviously I didn't.

@skonto
Copy link
Contributor

skonto commented Jun 28, 2023

/approve

@skonto skonto added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2023
@knative-prow
Copy link

knative-prow bot commented Jun 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: creydr, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit dc8e365 into knative:main Jun 28, 2023
2 checks passed
@creydr
Copy link
Member Author

creydr commented Jun 28, 2023

Sorry for that, initially I spotted it and I thought I fixed it everywhere but obviously I didn't.

np. Can we manually rerun the "Update-community" job, so the PRs get fixed?

@skonto
Copy link
Contributor

skonto commented Jun 28, 2023

This merge will trigger an update no? cc @dprotaso

@pierDipi
Copy link
Member

Sorry for that, initially I spotted it and I thought I fixed it everywhere but obviously I didn't.

np. Can we manually rerun the "Update-community" job, so the PRs get fixed?

https://github.com/knative-sandbox/knobots/actions/runs/5399920630

This was referenced Jun 28, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jun 28, 2023
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
knative-prow bot pushed a commit to knative/eventing that referenced this pull request Jun 28, 2023
@knative-automation
[main] Update community files (#7043)
4b5fde8 
Fix typo knative/community#1389 -pierDipi

Produced by: knative-sandbox/knobots/actions/update-community

Details:
```

```

Signed-off-by: Knative Automation <[email protected]>
@skonto
Copy link
Contributor

skonto commented Jun 28, 2023

Ok this is manual then good to know, I could have run it if it was mentioned :)

@skonto
Copy link
Contributor

skonto commented Jun 28, 2023 •
edited
Loading

The test-infra PR is not required for https://github.com/knative/release/actions/workflows/check-owners.yaml to pass, it seems blocked.

vishal-chdhry pushed a commit to vishal-chdhry/eventing that referenced this pull request Jul 6, 2023
@knative-automation @vishal-chdhry
[main] Update community files (knative#7043)
8c3f6de 
Fix typo knative/community#1389 -pierDipi

Produced by: knative-sandbox/knobots/actions/update-community

Details:
```

```

Signed-off-by: Knative Automation <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krsna-m krsna-m Awaiting requested review from krsna-m

@zroubalik zroubalik Awaiting requested review from zroubalik

@skonto skonto Awaiting requested review from skonto

Assignees

@dprotaso dprotaso

@zroubalik zroubalik

@skonto skonto

@krsna-m krsna-m

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@creydr @skonto @pierDipi @dprotaso @zroubalik @krsna-m