Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @pymhq as Member for Knative Sandbox #1340

Merged
merged 1 commit into from
May 3, 2023
Merged

Conversation

pymhq
Copy link
Member

@pymhq pymhq commented May 3, 2023

Request to join as Member for Knative Sandbox

Changes

Request to join as Member for Knative Sandbox

/kind

Fixes #

Release Note


Docs


Request to join as Member for Knative Sandbox
@knative-prow
Copy link

knative-prow bot commented May 3, 2023

@pymhq: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Request to join as Member for Knative Sandbox

Changes

Request to join as Member for Knative Sandbox

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 3, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: pymhq / name: Peng, YM (Andy) (7662dc5)

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 3, 2023
@knative-prow
Copy link

knative-prow bot commented May 3, 2023

Hi @pymhq. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 3, 2023
@dprotaso
Copy link
Member

dprotaso commented May 3, 2023

Note for others: Andy is a CNCF ambassador who's going to be focused on Knative

/lgtm
/approve
/ok-to-test
/easycla

@knative-prow knative-prow bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 3, 2023
@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 3, 2023
@knative-prow
Copy link

knative-prow bot commented May 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, pymhq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2023
@knative-prow knative-prow bot merged commit fd2cd3c into knative:main May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants