Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Initial files for 2023 TOC Elections #1332

Merged
merged 11 commits into from
May 3, 2023

Conversation

geekygirldawn
Copy link
Member

Here is a PR with the initial files required to kick off the Knative 2023 TOC elections.

Before this PR can be merged:

  • @jberkus needs to confirm that he can have everything needed to set up Elekto done by May 2.
  • @knative/steering-committee needs to officially appoint the election officers. We've proposed @geekygirldawn and @aliok.
  • @knative/steering-committee needs to make sure they are OK with the timeline and other details proposed in this PR.

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2023
@knative-prow knative-prow bot requested review from lance and puerco April 26, 2023 12:50
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 26, 2023
@geekygirldawn
Copy link
Member Author

Note: I've left @jberkus in the OWNERS file deliberately in case there are any urgent issues, especially related to Elekto, that might come up when the Election Officers are offline (esp due to time zones).

@geekygirldawn
Copy link
Member Author

Note: There is bugfix for Elekto that needs to be pushed before this PR is merged. The plan is for it to be merged before the end of the week.

Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I compared files with Knative TOC 2022 election and Kubernetes SC 2022 election files. Suggested some optional minor changes.

I am curious about the [email protected] address though.

All good!

elections/2023-TOC/README.md Show resolved Hide resolved
elections/2023-TOC/README.md Outdated Show resolved Hide resolved
elections/2023-TOC/README.md Outdated Show resolved Hide resolved
elections/2023-TOC/README.md Show resolved Hide resolved
- [Dawn Foster](https://github.com/geekygirldawn)
- [Ali Ok](https://github.com/aliok)

You can reach us by emailing [email protected]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who receives mails to this address? Are we sure that this inbox is working?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good question! That alias is configured in groups.yaml and I've updated it there as another commit within this PR. We'll need to wait until the PR is merged and then test it to make sure it's working.

elections/2023-TOC/README.md Outdated Show resolved Hide resolved
elections/2023-TOC/README.md Show resolved Hide resolved
Copy link

@Onceagain12 Onceagain12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summit

@knative-prow
Copy link

knative-prow bot commented Apr 27, 2023

@Onceagain12: changing LGTM is restricted to collaborators

In response to this:

Summit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall - thanks for getting this going, @geekygirldawn! I just have a few minor comments

elections/2023-TOC/README.md Outdated Show resolved Hide resolved
elections/2023-TOC/README.md Outdated Show resolved Hide resolved
elections/2023-TOC/README.md Outdated Show resolved Hide resolved
elections/2023-TOC/election_desc.md Outdated Show resolved Hide resolved
geekygirldawn and others added 2 commits May 1, 2023 07:30
Applied several changes to improve wording / clarity.

Co-authored-by: Lance Ball <[email protected]>
@geekygirldawn
Copy link
Member Author

I've addressed all of the feedback on this PR, so we can remove the hold and merge the PR as soon as @jberkus confirms that he's pushed the changes to Elekto that we needed.

elections/2023-TOC/README.md Outdated Show resolved Hide resolved
elections/2023-TOC/README.md Outdated Show resolved Hide resolved
@@ -24,4 +24,4 @@ groups:
members:
- [email protected]
- [email protected]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably take me off here; I'm not an officer this time.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked about this and would like to leave Josh on the ML for the election officers in case there are any urgent Elekto issues that come up in Pacific time, since Ali and I are both in European time zones.

elections/2023-TOC/voters.yaml Outdated Show resolved Hide resolved
@geekygirldawn
Copy link
Member Author

We've pushed the announcement date for the election to May 3 to give Josh some extra time to set up Elekto and make sure we have everything ready for the announcement.

elections/2023-TOC/README.md Outdated Show resolved Hide resolved
@jberkus
Copy link
Contributor

jberkus commented May 2, 2023

/remove-hold
/lgtm

Ready to merge.

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 2, 2023
@salaboy
Copy link
Member

salaboy commented May 3, 2023

/lgtm

@salaboy salaboy self-requested a review May 3, 2023 07:13
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2023
@salaboy
Copy link
Member

salaboy commented May 3, 2023

/approve

@knative-prow
Copy link

knative-prow bot commented May 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geekygirldawn, Onceagain12, salaboy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit c34a8ef into knative:main May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants