-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT: Initial files for 2023 TOC Elections #1332
Conversation
Note: I've left @jberkus in the OWNERS file deliberately in case there are any urgent issues, especially related to Elekto, that might come up when the Election Officers are offline (esp due to time zones). |
Note: There is bugfix for Elekto that needs to be pushed before this PR is merged. The plan is for it to be merged before the end of the week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I compared files with Knative TOC 2022 election and Kubernetes SC 2022 election files. Suggested some optional minor changes.
I am curious about the [email protected] address though.
All good!
- [Dawn Foster](https://github.com/geekygirldawn) | ||
- [Ali Ok](https://github.com/aliok) | ||
|
||
You can reach us by emailing [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who receives mails to this address? Are we sure that this inbox is working?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good question! That alias is configured in groups.yaml and I've updated it there as another commit within this PR. We'll need to wait until the PR is merged and then test it to make sure it's working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summit
@Onceagain12: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall - thanks for getting this going, @geekygirldawn! I just have a few minor comments
Applied several changes to improve wording / clarity. Co-authored-by: Lance Ball <[email protected]>
I've addressed all of the feedback on this PR, so we can remove the hold and merge the PR as soon as @jberkus confirms that he's pushed the changes to Elekto that we needed. |
@@ -24,4 +24,4 @@ groups: | |||
members: | |||
- [email protected] | |||
- [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably take me off here; I'm not an officer this time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We talked about this and would like to leave Josh on the ML for the election officers in case there are any urgent Elekto issues that come up in Pacific time, since Ali and I are both in European time zones.
Made several updates that clarify and correct some information about Elekto Co-authored-by: Josh Berkus <[email protected]>
…sh more time to set up Elekto
We've pushed the announcement date for the election to May 3 to give Josh some extra time to set up Elekto and make sure we have everything ready for the announcement. |
Co-authored-by: Ali Ok <[email protected]>
/remove-hold Ready to merge. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: geekygirldawn, Onceagain12, salaboy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Here is a PR with the initial files required to kick off the Knative 2023 TOC elections.
Before this PR can be merged:
/hold