Skip to content

Fix/1946 traffic split export #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 23, 2025
Merged

Fix/1946 traffic split export #2007

merged 3 commits into from
Jul 23, 2025
+17 −0

Conversation

thiagomedina
Copy link
Contributor

@thiagomedina thiagomedina commented Jul 10, 2025 •
edited by dsimansk
Loading

Changes

  • Include revisionName of lastRevision on exports with traffic split

Reference

Fixes #1946

Release Note

Fix service export with traffic split to include `revisionName` of `lastRevision`

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2025
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jul 10, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 10, 2025

Welcome @thiagomedina! It looks like this is your first PR to knative/client 🎉

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 10, 2025
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 10, 2025

Hi @thiagomedina. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow[bot]
knative-prow bot reviewed Jul 10, 2025
View reviewed changes
Copy link

@knative-prow knative-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thiagomedina: 0 warnings.

In response to this:

Description

Changes

Reference

Fixes #

Release Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 10, 2025
@thiagomedina thiagomedina marked this pull request as draft July 10, 2025 22:02
@thiagomedina thiagomedina force-pushed the fix/1946-traffic-split-export branch from 7d7fe67 to c238f71 Compare July 10, 2025 22:10
@thiagomedina thiagomedina changed the title [WIP] Fix/1946 traffic split export Fix/1946 traffic split export Jul 16, 2025
@thiagomedina thiagomedina marked this pull request as ready for review July 16, 2025 13:07
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2025
@thiagomedina thiagomedina marked this pull request as draft July 16, 2025 13:08
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2025
@thiagomedina thiagomedina marked this pull request as ready for review July 17, 2025 22:55
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 17, 2025
@knative-prow knative-prow bot requested a review from dsimansk July 17, 2025 22:55
@dsimansk
Copy link
Contributor

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 18, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.06%. Comparing base (1c3b47c) to head (4b135f6).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2007   +/-   ##
=======================================
  Coverage   70.05%   70.06%           
=======================================
  Files         233      233           
  Lines       16461    16464    +3     
=======================================
+ Hits        11532    11535    +3     
  Misses       4123     4123           
  Partials      806      806

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 19, 2025
@thiagomedina
Copy link
Contributor Author

/retest-required

@dsimansk dsimansk added the kind/bug Categorizes issue or PR as related to a bug. label Jul 23, 2025
@dsimansk
Copy link
Contributor

@thiagomedina thanks looks good!

@dsimansk
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2025
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, thiagomedina

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2025
@knative-prow knative-prow bot merged commit 268aba6 into knative:main Jul 23, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow knative-prow[bot] knative-prow[bot] left review comments

@dprotaso dprotaso Awaiting requested review from dprotaso

@gauron99 gauron99 Awaiting requested review from gauron99

@itsmurugappan itsmurugappan Awaiting requested review from itsmurugappan

@dsimansk dsimansk Awaiting requested review from dsimansk

Assignees

@dsimansk dsimansk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kn service export doesn't work with traffic splits
2 participants
@thiagomedina @dsimansk