Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update-hack knobots action #214

Closed
wants to merge 1 commit into from
Closed

Add update-hack knobots action #214

wants to merge 1 commit into from

Conversation

upodroid
Copy link
Contributor

Part of knative/infra#134
For now, only test-infra is being synced.

/cc @dprotaso @kvmware

@knative-prow knative-prow bot requested review from dprotaso and krsna-m July 12, 2022 10:14
@knative-prow
Copy link

knative-prow bot commented Jul 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2022
@upodroid upodroid changed the title Add hack knobots action Add update-hack knobots action Jul 12, 2022
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 12, 2022
@krsna-m
Copy link
Contributor

krsna-m commented Jul 12, 2022

@upodroid
Copy link
Contributor Author

Not quite. knative/hack is currently distributed as a vendored go module. When we get rid of vendor, we need to distribute it in a different way which will be done by update-hack action.

@krsna-m
Copy link
Contributor

krsna-m commented Jul 12, 2022

As per the feedback from our WG share out, a proposal needs to be written and agreed upon before we rip out vendor. Let's get everyone on the same page before we start making changes?

@upodroid
Copy link
Contributor Author

upodroid commented Jul 12, 2022

I remember, if we merge this as is, it would only run against test-infra which is fine. We don't release anything from that repo.

Working on the proposal doc.

@krsna-m
Copy link
Contributor

krsna-m commented Mar 30, 2023

closing this now until there is a proposal doc and the infra/toolbox spit is done.

@krsna-m krsna-m closed this Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants