change ads->kernel-native and workload->duel-engine in code
#940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: LiZhenCheng9527 <[email protected]>
kmesh-bot
requested review from
bitcoffeeiux,
hzxuzhonghu,
nlgwcy,
Okabe-Rintarou-0 and
tacslon
|
What is the conclusion from community meeting? |
|
Change the name of the constant first, and the name of the API later. |
|
I think changing the functions name can be a |
|
There is a typo that |
hzxuzhonghu
reviewed
Oct 11, 2024
ctl/dump/dump.go
Outdated
| # Workload mode: | ||
| kmeshctl dump <kmesh-daemon-pod> workload`, | ||
| # Duel Engine mode: | ||
| kmeshctl dump <kmesh-daemon-pod> duel-engine`, |
hzxuzhonghu
reviewed
Oct 11, 2024
ctl/dump/dump.go
Outdated
| @@ -54,8 +54,8 @@ kmeshctl dump <kmesh-daemon-pod> workload`, | |||
| func RunDump(cmd *cobra.Command, args []string) error { | |||
| podName := args[0] | |||
| mode := args[1] | |||
| if mode != "ads" && mode != "workload" { | |||
| log.Errorf("Error: Argument must be 'ads' or 'workload'") | |||
| if mode != "kernel-native" && mode != "duel-engine" { | |||
There was a problem hiding this comment.
can define a const instead of hardcoding
hzxuzhonghu
reviewed
Oct 11, 2024
deploy/charts/kmesh-helm/values.yaml
Outdated
| @@ -7,7 +7,7 @@ deploy: | |||
| tag: latest | |||
| imagePullPolicy: IfNotPresent | |||
| containers: | |||
| kmeshDaemonArgs: "--mode=workload --enable-bypass=false --enable-bpf-log=true" | |||
| kmeshDaemonArgs: "--mode=duel-engine --enable-bypass=false --enable-bpf-log=true" | |||
Signed-off-by: LiZhenCheng9527 <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #937
Special notes for your reviewer:
Does this PR introduce a user-facing change?: