Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a github action to publish release assets automatically #938

Merged
merged 4 commits into from
Oct 12, 2024

Conversation

LiZhenCheng9527
Copy link
Collaborator

What type of PR is this?
/kind enhancement

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #891

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: LiZhenCheng9527 <[email protected]>
Signed-off-by: LiZhenCheng9527 <[email protected]>
@kmesh-bot kmesh-bot added the kind/enhancement New feature or request label Oct 10, 2024
@LiZhenCheng9527
Copy link
Collaborator Author

Results of the experimental:https://github.com/LiZhenCheng9527/kmesh/releases/tag/v7.5.2

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.47%. Comparing base (43b3aab) to head (edd569a).
Report is 32 commits behind head on main.

see 24 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec2d3bd...edd569a. Read the comment docs.

@YaoZengzeng
Copy link
Member

/lgtm

.github/workflows/release.yml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
- name: Making helm package
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also need a step to do helm-push

@hzxuzhonghu
Copy link
Member

/cherry-pick release-0.5

@kmesh-bot
Copy link
Collaborator

@hzxuzhonghu: once the present PR merges, I will cherry-pick it on top of release-0.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: LiZhenCheng9527 <[email protected]>
@kmesh-bot kmesh-bot removed the lgtm label Oct 10, 2024
Signed-off-by: LiZhenCheng9527 <[email protected]>
@hzxuzhonghu
Copy link
Member

/lgtm
/approve

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hzxuzhonghu
Copy link
Member

/lgtm

@kmesh-bot kmesh-bot added the lgtm label Oct 12, 2024
@kmesh-bot kmesh-bot merged commit e5a1cf7 into kmesh-net:main Oct 12, 2024
9 checks passed
@kmesh-bot
Copy link
Collaborator

@hzxuzhonghu: new pull request created: #947

In response to this:

/cherry-pick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a github action to publish release artifacts automatically
4 participants