Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable/disable accesslog with kmeshctl #935

Merged
merged 3 commits into from
Oct 10, 2024
Merged

enable/disable accesslog with kmeshctl #935

merged 3 commits into from
Oct 10, 2024

Conversation

LiZhenCheng9527
Copy link
Collaborator

What type of PR is this?
/kind enhancement

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #925

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@kmesh-bot kmesh-bot added the kind/enhancement New feature or request label Oct 8, 2024
@LiZhenCheng9527
Copy link
Collaborator Author

/cc @YaoZengzeng PTAL

@kmesh-bot
Copy link
Collaborator

@LiZhenCheng9527: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only kmesh-net members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @YaoZengzeng PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov Codecov
Copy link

codecov bot commented Oct 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 28.57143% with 15 lines in your changes missing coverage. Please review.

Project coverage is 54.56%. Comparing base (ef71fe9) to head (577fdb9).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
pkg/status/status_server.go 46.15% 4 Missing and 3 partials ⚠️
pkg/controller/telemetry/metric.go 0.00% 4 Missing ⚠️
pkg/controller/workload/workload_controller.go 0.00% 4 Missing ⚠️
Files with missing lines Coverage Δ
pkg/controller/telemetry/metric.go 56.36% <0.00%> (-0.19%) ⬇️
pkg/controller/workload/workload_controller.go 58.18% <0.00%> (-4.57%) ⬇️
pkg/status/status_server.go 40.98% <46.15%> (+0.24%) ⬆️

... and 4 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99e0c0c...577fdb9. Read the comment docs.

@hzxuzhonghu hzxuzhonghu changed the title Starting and shutting down accesslog with kmeshctl enable/disable accesslog with kmeshctl Oct 8, 2024
hzxuzhonghu
hzxuzhonghu reviewed Oct 8, 2024
View reviewed changes
pkg/status/status_server.go Show resolved Hide resolved
pkg/status/status_server.go Outdated Show resolved Hide resolved
hzxuzhonghu
hzxuzhonghu reviewed Oct 10, 2024
View reviewed changes
ctl/accesslog/accesslog.go
patternAccesslog = "/accesslog"
)

var log = logger.NewLoggerScope("kmeshctl/accesslog")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everytime we use a logger we need to init one, i do think we can provide a default logger in the package. So in some common place, it can be used

hzxuzhonghu
hzxuzhonghu reviewed Oct 10, 2024
View reviewed changes
ctl/utils/utils.go Outdated Show resolved Hide resolved
@LiZhenCheng9527
resolve conflict
577fdb9 
Signed-off-by: LiZhenCheng9527 <[email protected]>
@hzxuzhonghu
Copy link
Member

/lgtm
/approve

@kmesh-bot kmesh-bot added the lgtm label Oct 10, 2024
@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 67058b5 into kmesh-net:main Oct 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YaoZengzeng YaoZengzeng YaoZengzeng left review comments

@hzxuzhonghu hzxuzhonghu hzxuzhonghu left review comments

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

@nlgwcy nlgwcy Awaiting requested review from nlgwcy

@Okabe-Rintarou-0 Okabe-Rintarou-0 Awaiting requested review from Okabe-Rintarou-0

Assignees

@hzxuzhonghu hzxuzhonghu

Labels
approved kind/enhancement New feature or request lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Starting and shutting down accesslog with kmeshctl
4 participants
@LiZhenCheng9527 @kmesh-bot @hzxuzhonghu @YaoZengzeng