Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm depends/include/bpf_helper_defs_ext.h #916

Merged
merged 3 commits into from
Oct 12, 2024

Conversation

hzxuzhonghu
Copy link
Member

@hzxuzhonghu hzxuzhonghu commented Sep 30, 2024

What type of PR is this?

What this PR does / why we need it:

bpf/include/bpf_helper_defs_ext.h is generated from this depends/include/bpf_helper_defs_ext.h

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@LiZhenCheng9527
Copy link
Collaborator

/lgtm

@hzxuzhonghu hzxuzhonghu changed the title update license rm depends/include/bpf_helper_defs_ext.h Sep 30, 2024
bpf/include/common.h Outdated Show resolved Hide resolved
@hzxuzhonghu
Copy link
Member Author

hzxuzhonghu commented Oct 8, 2024

/retest

Weird, this test failed

=== NAME  TestHandleKmeshManage/10._ns_without_label,_pod_ready_add_without_annotation
    manage_controller_test.go:186: 
        	Error Trace:	/home/runner/work/kmesh/kmesh/pkg/controller/manage/manage_controller_test.go:186
        	            				/home/runner/work/kmesh/kmesh/pkg/controller/manage/manage_controller_test.go:425
        	Error:      	Not equal: 
        	            	expected: false
        	            	actual  : true
        	Test:       	TestHandleKmeshManage/10._ns_without_label,_pod_ready_add_without_annotation
        	Messages:   	unexpected value for disabled flag

@Okabe-Rintarou-0

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.91%. Comparing base (ef71fe9) to head (0a7735d).
Report is 38 commits behind head on main.

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18c383a...0a7735d. Read the comment docs.

Signed-off-by: Zhonghu Xu <[email protected]>
Signed-off-by: Zhonghu Xu <[email protected]>
@hzxuzhonghu
Copy link
Member Author

/assign @lec-bit

@nlgwcy
Copy link
Contributor

nlgwcy commented Oct 12, 2024

/lgtm
/approve

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nlgwcy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit b85ca41 into kmesh-net:main Oct 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants