Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick #610 to Release 0.5 #908

Closed
wants to merge 25 commits into from
Closed

Conversation

nlgwcy
Copy link
Contributor

@nlgwcy nlgwcy commented Sep 27, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


hzxuzhonghu and others added 25 commits September 25, 2024 09:18
…lease-0.5

[release-0.5] Fix build warning and remove docker pull explicitly
Signed-off-by: Zhonghu Xu <[email protected]>
Signed-off-by: wuchangye <[email protected]>
Signed-off-by: wuchangye <[email protected]>
Signed-off-by: wuchangye <[email protected]>
Signed-off-by: wuchangye <[email protected]>
Signed-off-by: wuchangye <[email protected]>
Signed-off-by: wuchangye <[email protected]>
Signed-off-by: wuchangye <[email protected]>
Signed-off-by: wuchangye <[email protected]>
Signed-off-by: wuchangye <[email protected]>
Signed-off-by: wuchangye <[email protected]>
@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from nlgwcy. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot
Copy link
Collaborator

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 53.15%. Comparing base (0af61e9) to head (ef9e1e5).
Report is 41 commits behind head on main.

Files with missing lines Patch % Lines
pkg/bpf/bpf.go 50.00% 2 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
pkg/bpf/bpf.go 43.60% <50.00%> (+2.53%) ⬆️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48d3608...ef9e1e5. Read the comment docs.

@nlgwcy
Copy link
Contributor Author

nlgwcy commented Sep 27, 2024

/close

@kmesh-bot kmesh-bot closed this Sep 27, 2024
@kmesh-bot
Copy link
Collaborator

@nlgwcy: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants