Add locality loadbalance to kmesh workload mode. #900
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,141 @@ | ||
| /* | ||
| * Copyright The Kmesh Authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at: | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package bpfcache | ||
|
|
||
| import ( | ||
| "sync" | ||
|
|
||
| "kmesh.net/kmesh/api/v2/workloadapi" | ||
| ) | ||
|
|
||
| const ( | ||
| REGION = 1 << iota // 000001 | ||
| ZONE // 000010 | ||
| SUBZONE // 000100 | ||
| NODENAME // 001000 | ||
| CLUSTERID // 010000 | ||
| NETWORK // 100000 | ||
| ) | ||
|
|
||
| type localityInfo struct { | ||
| region string // init from workload.GetLocality().GetRegion() | ||
| zone string // init from workload.GetLocality().GetZone() | ||
| subZone string // init from workload.GetLocality().GetSubZone() | ||
| nodeName string // init from os.Getenv("NODE_NAME"), workload.GetNode() | ||
| clusterId string // init from workload.GetClusterId() | ||
| network string // workload.GetNetwork() | ||
| mask uint32 // mask | ||
| } | ||
|
|
||
| func Valid(s string) bool { | ||
| return s != "" | ||
| } | ||
|
|
||
| func (l *localityInfo) Set(s string, param uint32) { | ||
| if !Valid(s) { | ||
| return | ||
| } | ||
| switch param { | ||
| case REGION: | ||
| l.region = s | ||
| case ZONE: | ||
| l.zone = s | ||
| case SUBZONE: | ||
| l.subZone = s | ||
| case NODENAME: | ||
| l.nodeName = s | ||
| case CLUSTERID: | ||
| l.clusterId = s | ||
| case NETWORK: | ||
| l.network = s | ||
| } | ||
| l.mask |= param | ||
| } | ||
|
|
||
| func (l *localityInfo) Clear(param uint32) { | ||
| l.mask &= ^param | ||
| } | ||
|
|
||
| func (l *localityInfo) IsSet(param uint32) bool { | ||
| return l.mask¶m != 0 | ||
| } | ||
|
|
||
| type LocalityCache struct { | ||
| mutex sync.RWMutex | ||
| LocalityInfo *localityInfo | ||
| } | ||
|
|
||
| func NewLocalityCache() LocalityCache { | ||
| return LocalityCache{ | ||
| LocalityInfo: nil, | ||
| } | ||
| } | ||
|
|
||
| func (l *LocalityCache) SetLocality(nodeName, clusterId, network string, locality *workloadapi.Locality) { | ||
| l.mutex.Lock() | ||
| defer l.mutex.Unlock() | ||
| if l.LocalityInfo == nil { | ||
| l.LocalityInfo = &localityInfo{} | ||
| } | ||
|
|
||
| // notice: nodeName should set by processor or os.Getenv("NODE_NAME"), | ||
| l.LocalityInfo.Set(nodeName, NODENAME) | ||
| l.LocalityInfo.Set(locality.GetRegion(), REGION) | ||
| l.LocalityInfo.Set(locality.GetSubzone(), SUBZONE) | ||
| l.LocalityInfo.Set(locality.GetZone(), ZONE) | ||
| l.LocalityInfo.Set(clusterId, CLUSTERID) | ||
| l.LocalityInfo.Set(network, NETWORK) | ||
| } | ||
|
|
||
| func (l *LocalityCache) CalcLocalityLBPrio(wl *workloadapi.Workload, rp []workloadapi.LoadBalancing_Scope) uint32 { | ||
| var rank uint32 = 0 | ||
| for _, scope := range rp { | ||
| switch scope { | ||
| case workloadapi.LoadBalancing_REGION: | ||
| log.Debugf("l.LocalityInfo.region %#v, wl.GetLocality().GetRegion() %#v", l.LocalityInfo.region, wl.GetLocality().GetRegion()) | ||
| if l.LocalityInfo.region == wl.GetLocality().GetRegion() { | ||
| rank++ | ||
| } | ||
| case workloadapi.LoadBalancing_ZONE: | ||
| log.Debugf("l.LocalityInfo.zone %#v, wl.GetLocality().GetZone() %#v", l.LocalityInfo.zone, wl.GetLocality().GetZone()) | ||
| if l.LocalityInfo.zone == wl.GetLocality().GetZone() { | ||
| rank++ | ||
| } | ||
| case workloadapi.LoadBalancing_SUBZONE: | ||
| log.Debugf("l.LocalityInfo.subZone %#v, wl.GetLocality().GetSubzone() %#v", l.LocalityInfo.subZone, wl.GetLocality().GetSubzone()) | ||
| if l.LocalityInfo.subZone == wl.GetLocality().GetSubzone() { | ||
| rank++ | ||
| } | ||
| case workloadapi.LoadBalancing_NODE: | ||
| log.Debugf("l.LocalityInfo.nodeName %#v, wl.GetNode() %#v", l.LocalityInfo.nodeName, wl.GetNode()) | ||
| if l.LocalityInfo.nodeName == wl.GetNode() { | ||
| rank++ | ||
| } | ||
| case workloadapi.LoadBalancing_NETWORK: | ||
| log.Debugf("l.LocalityInfo.network %#v, wl.GetNetwork() %#v", l.LocalityInfo.network, wl.GetNetwork()) | ||
| if l.LocalityInfo.network == wl.GetNetwork() { | ||
| rank++ | ||
| } | ||
| case workloadapi.LoadBalancing_CLUSTER: | ||
| log.Debugf("l.LocalityInfo.clusterId %#v, wl.GetClusterId() %#v", l.LocalityInfo.clusterId, wl.GetClusterId()) | ||
| if l.LocalityInfo.clusterId == wl.GetClusterId() { | ||
| rank++ | ||
| } | ||
| } | ||
| } | ||
| return uint32(len(rp)) - rank | ||
|
There was a problem hiding this comment. This method is not right. Keep in mind, we shoud match rp []workloadapi.LoadBalancing_Scope in order, if one doesnot match, we should stop. So i am super sure this result now is nort right. There was a problem hiding this comment. There is not test coverage, i will write a test later to test your function. I am feeling this function is still not correct |
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.