e2e test for Kmesh daemon restart #661
Conversation
Signed-off-by: YaoZengzeng <[email protected]>
|
/hold |
Codecov ReportAll modified and coverable lines are covered by tests ✅
see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Signed-off-by: YaoZengzeng <[email protected]>
YaoZengzeng
force-pushed
the
e2e-restart
branch
from
5d346fb
to
5f467af
Compare
Signed-off-by: YaoZengzeng <[email protected]>
YaoZengzeng
force-pushed
the
e2e-restart
branch
from
5f467af
to
45ec225
Compare
|
/unhold |
|
@hzxuzhonghu PTAL |
test/e2e/baseline_test.go
Outdated
| @@ -574,6 +578,73 @@ func TestRemoveAddNsOrServiceWaypoint(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestKmeshRestart(t *testing.T) { | |||
There was a problem hiding this comment.
Prefer split restart tests into restart_test.go
| @@ -176,6 +180,7 @@ func SetupApps(t resource.Context, i istio.Instance, apps *EchoDeployments) erro | |||
| } | |||
| apps.All = echos | |||
| apps.EnrolledToKmesh = match.ServiceName(echo.NamespacedName{Name: EnrolledToKmesh, Namespace: apps.Namespace}).GetMatches(echos) | |||
| apps.ServiceWithWaypointAtServiceGranularity = match.ServiceName(echo.NamespacedName{Name: ServiceWithWaypointAtServiceGranularity, Namespace: apps.Namespace}).GetMatches(echos) | |||
There was a problem hiding this comment.
I am confused how did you test waypoint-captuired service before without an app
There was a problem hiding this comment.
waypoint-captured service has always existed. We are not going to creat here, but just assign it to this variable for easy use in test case later.
Signed-off-by: YaoZengzeng <[email protected]>
|
@hzxuzhonghu updated |
| @@ -74,6 +74,9 @@ type EchoDeployments struct { | |||
| // The echo service which is enrolled to Kmesh without waypoint. | |||
| EnrolledToKmesh echo.Instances | |||
|
|
|||
| // The echo service which is enrolled to Kmesh and with service waypoint. | |||
| ServiceWithWaypointAtServiceGranularity echo.Instances | |||
|
|
|||
| // WaypointProxies by | |||
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Add E2E case for that managed applications can work properly before, during and after Kmesh daemon restart
Which issue(s) this PR fixes:
Fixes part of #642
Special notes for your reviewer:
Does this PR introduce a user-facing change?: