Enable cleanup in E2E #639
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
see 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
test/e2e/run_test.sh
Outdated
| CLEANUP_REGISTRY=true | ||
| shift | ||
| ;; | ||
| --cleanup-all) |
There was a problem hiding this comment.
I think cleanup both kind and dockerregistry is meaningful, not only one of them
test/e2e/run_test.sh
Outdated
| } | ||
|
|
||
| function cleanup_docker_registry() { | ||
| local REG_NAME="${KIND_REGISTRY_NAME:-kind-registry}" |
There was a problem hiding this comment.
We could use KIND_REGISTRY_NAME directly, it couldn't be configured now.
|
@noobwei should rebase first, as I've modified |
Signed-off-by: YaoZengzeng <[email protected]>
Signed-off-by: YaoZengzeng <[email protected]>
Signed-off-by: YaoZengzeng <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: Zhonghu Xu <[email protected]>
Signed-off-by: Zhonghu Xu <[email protected]>
Signed-off-by: Zhonghu Xu <[email protected]>
Signed-off-by: Zhonghu Xu <[email protected]>
Bumps [github.com/containernetworking/cni](https://github.com/containernetworking/cni) from 1.2.2 to 1.2.3. - [Release notes](https://github.com/containernetworking/cni/releases) - [Commits](containernetworking/cni@v1.2.2...v1.2.3) --- updated-dependencies: - dependency-name: github.com/containernetworking/cni dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: wuchangye <[email protected]>
Signed-off-by: YaoZengzeng <[email protected]>
Signed-off-by: YaoZengzeng <[email protected]>
Signed-off-by: YaoZengzeng <[email protected]>
Signed-off-by: Zhonghu Xu <[email protected]>
Signed-off-by: Zhonghu Xu <[email protected]>
Signed-off-by: Zhonghu Xu <[email protected]>
Signed-off-by: Zhonghu Xu <[email protected]>
Signed-off-by: Zhonghu Xu <[email protected]>
Signed-off-by: Zhonghu Xu <[email protected]>
Signed-off-by: Zhonghu Xu <[email protected]>
Signed-off-by: Zhonghu Xu <[email protected]>
Signed-off-by: Zhonghu Xu <[email protected]>
Signed-off-by: Zhonghu Xu <[email protected]>
Signed-off-by: noobwei <[email protected]>
Signed-off-by: noobwei <[email protected]>
|
Actually you don't need to close this PR, just use "git push -f" to force overwrite. |
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Enable cleanup in E2E, include cleanup the kind cluster or docker registry or both
Which issue(s) this PR fixes:
Fixes #522
Special notes for your reviewer:
Does this PR introduce a user-facing change?: