Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metrics of service #629

Closed
wants to merge 2 commits into from

Conversation

LiZhenCheng9527
Copy link
Collaborator

@LiZhenCheng9527 LiZhenCheng9527 commented Jul 23, 2024

What type of PR is this?
/kind bug
/kind enhancement

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@kmesh-bot kmesh-bot added the kind/bug Something isn't working label Jul 23, 2024
@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hzxuzhonghu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 71.68142% with 32 lines in your changes missing coverage. Please review.

Project coverage is 49.37%. Comparing base (4a7807b) to head (b4b60e4).
Report is 18 commits behind head on main.

Files Coverage Δ
pkg/controller/telemetry/utils.go 77.77% <100.00%> (+1.30%) ⬆️
pkg/auth/rbac.go 80.97% <87.50%> (+0.20%) ⬆️
pkg/controller/telemetry/metric.go 59.67% <69.90%> (+5.89%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df8b1b0...b4b60e4. Read the comment docs.

@LiZhenCheng9527
Copy link
Collaborator Author

LiZhenCheng9527 commented Jul 24, 2024

/cc @hzxuzhonghu this pr is ready to merge
Completing validation in the 5.10 kernel

@kmesh-bot
Copy link
Collaborator

@LiZhenCheng9527: GitHub didn't allow me to request PR reviews from the following users: to, merge, this, pr, is, ready.

Note that only kmesh-net members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @hzxuzhonghu this pr is ready to merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kmesh-bot kmesh-bot added size/XL and removed size/XS labels Jul 27, 2024
@LiZhenCheng9527 LiZhenCheng9527 changed the title fix reporter destination port error add metrics of service Jul 27, 2024
@LiZhenCheng9527 LiZhenCheng9527 added the kind/enhancement New feature or request label Jul 27, 2024
@LiZhenCheng9527
Copy link
Collaborator Author

/hold

Signed-off-by: LiZhenCheng9527 <[email protected]>
Signed-off-by: LiZhenCheng9527 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold kind/bug Something isn't working kind/enhancement New feature or request size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants