-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tcp long connections metrics #1249
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@nlgwcy @LemmyHuang @xiangxinyong can you review the pr, have i writen correct ebpf code, i have done the changes which has been told in previous comments in the proposal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please present the results of the long connection metrics
- The original destination address problem is still unhandle. If you plan to optimize later, you can create a sub-issue under the existing lfx issue to track the task.
pkg/controller/telemetry/metric.go
Outdated
@@ -55,6 +55,7 @@ type MetricController struct { | |||
EnableAccesslog atomic.Bool | |||
EnableMonitoring atomic.Bool | |||
EnableWorkloadMetric atomic.Bool | |||
EnableLongTCPMetric atomic.Bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's necessary to distinguish between metrics for long connections and short connections.
As long as metrics is turned on, we should handle all types of connections.
bpf/kmesh/workload/include/config.h
Outdated
#define kmesh_perf_map km_perf_map | ||
#define kmesh_perf_info km_perf_info | ||
#define map_of_long_tcp_conns km_longtcpconns_map | ||
#define long_tcp_conns_events km_longtcpconns_events |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BPF_OBJ_NAME_LEN = 16
So I think, this name of map is too long.
Signed-off-by: Yash Patel <[email protected]>
Signed-off-by: Yash Patel <[email protected]>
…userspace Signed-off-by: Yash Patel <[email protected]>
Signed-off-by: Yash Patel <[email protected]>
Signed-off-by: Yash Patel <[email protected]>
Signed-off-by: Yash Patel <[email protected]>
Signed-off-by: Yash Patel <[email protected]>
Signed-off-by: Yash Patel <[email protected]>
Signed-off-by: Yash Patel <[email protected]>
Signed-off-by: Yash Patel <[email protected]>
Signed-off-by: Yash Patel <[email protected]>
Signed-off-by: Yash Patel <[email protected]>
…km_longconn_ev ringbuff Signed-off-by: Yash Patel <[email protected]>
Signed-off-by: Yash Patel <[email protected]>
Signed-off-by: Yash Patel <[email protected]>
Signed-off-by: Yash Patel <[email protected]>
Signed-off-by: Yash Patel <[email protected]>
b79a168
to
a698cac
Compare
Signed-off-by: Yash Patel <[email protected]>
Signed-off-by: Yash Patel <[email protected]>
Signed-off-by: Yash Patel <[email protected]>
Signed-off-by: Yash Patel <[email protected]>
Signed-off-by: Yash Patel <[email protected]>
Signed-off-by: Yash Patel <[email protected]> rfac: bpf2go.go Signed-off-by: Yash Patel <[email protected]>
a3aa24e
to
37fa818
Compare
Signed-off-by: Yash Patel <[email protected]>
Signed-off-by: Yash Patel <[email protected]>
99d0e84
to
dfea824
Compare
Signed-off-by: Yash Patel <[email protected]>
dfea824
to
7fc5113
Compare
Signed-off-by: Yash Patel <[email protected]> rfac: rmoved workload/tc.go Signed-off-by: Yash Patel <[email protected]> chore: generated bpf2go Signed-off-by: Yash Patel <[email protected]> rfac: tc generated files Signed-off-by: Yash Patel <[email protected]>
Signed-off-by: Yash Patel <[email protected]>
76a940e
to
e4fb65d
Compare
Signed-off-by: Yash Patel <[email protected]> rfac: removed is_managed_by_kmesh_skb func Signed-off-by: Yash Patel <[email protected]>
c274149
to
3df32ec
Compare
Signed-off-by: Yash Patel <[email protected]> rfac: sendmsg.c Signed-off-by: Yash Patel <[email protected]> chore: generated bpf2go Signed-off-by: Yash Patel <[email protected]> rfac: added is_managed_by_kmesh to sendmsg.c Signed-off-by: Yash Patel <[email protected]>
3df32ec
to
e26073e
Compare
@LiZhenCheng9527 @nlgwcy can you look at the above error during bpf_compaitliblity test, why is this happening, i have also shorten the program length so that number of instruction sets not exceeds |
so the problem arrises in the line of code, with the error
when i try to comment these lines and run unit tests, verifier accept it. these lines are written previously in the sockops_prog
in the program
|
Signed-off-by: Yash Patel <[email protected]> chore: generated bpf2go Signed-off-by: Yash Patel <[email protected]>
Signed-off-by: Yash Patel <[email protected]>
d240f27
to
9a01a5a
Compare
Signed-off-by: Yash Patel <[email protected]>
9a01a5a
to
1ebbcb3
Compare
What type of PR is this?
/kind feature
What this PR does / why we need it:
The pr introduces new feature of tcp_long_conn metrics
Which issue(s) this PR fixes:
Fixes #1211
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Yes