Skip to content

Commit

Permalink
fix by comments
Browse files Browse the repository at this point in the history
Signed-off-by: LiZhenCheng9527 <[email protected]>
  • Loading branch information
LiZhenCheng9527 authored and kmesh-bot committed Oct 12, 2024
1 parent c26d5ea commit dfe05bb
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
11 changes: 6 additions & 5 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
name: Build Release

on:
release:
types:
- published
name: Build Release
permissions:
contents: read
jobs:
Expand All @@ -14,6 +16,7 @@ jobs:
strategy:
fail-fast: false
matrix:
go-version: [ '1.23' ]
target:
- kmeshctl
os:
Expand All @@ -27,15 +30,14 @@ jobs:
- name: Setup go
uses: actions/[email protected]
with:
go-version-file: go.mod
go-version: ${{ matrix.go-version }}

- name: Making and packaging
env:
GOOS: ${{ matrix.os }}
GOARCH: ${{ matrix.arch }}
run: make build-kmeshctl OUT=kmeshctl-${{ matrix.os }}-${{ matrix.arch }}
run: make kmeshctl OUT=kmeshctl-${{ matrix.os }}-${{ matrix.arch }}
- name: Uploading kmeshctl assets
if: ${{ !env.ACT }}
uses: softprops/action-gh-release@v2
with:
files: |
Expand All @@ -53,7 +55,6 @@ jobs:
VERSION: ${{ github.ref_name }}
run: make helm-package CHART_VERSION=${{ github.ref_name }}
- name: Uploading kmesh helm package
if: ${{ !env.ACT }}
uses: softprops/action-gh-release@v2
with:
files: |
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,8 @@ all:
$(GO) build -ldflags $(LDFLAGS) -o $(APPS4) $(GOFLAGS) ./ctl/main.go)

OUT ?= kmeshctl
.PHONY: build-kmeshctl
build-kmeshctl:
.PHONY: kmeshctl
kmeshctl:
$(call printlog, BUILD, $(APPS4))
$(QUIET) (export PKG_CONFIG_PATH=$(PKG_CONFIG_PATH):$(ROOT_DIR)mk; \
$(GO) build -o $(OUT) $(GOFLAGS) ./ctl/main.go)
Expand Down

0 comments on commit dfe05bb

Please sign in to comment.