Skip to content

Commit

Permalink
Merge pull request #800 from weli-l/dev/log
Browse files Browse the repository at this point in the history
fix verifier log omitted
  • Loading branch information
hzxuzhonghu authored Sep 2, 2024
2 parents 3bb72e2 + 1375e39 commit 304ae91
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 4 deletions.
7 changes: 6 additions & 1 deletion pkg/bpf/bpf.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ package bpf
// #include "cluster/cluster.pb-c.h"
import "C"
import (
"errors"
"fmt"
"hash/fnv"
"os"
Expand Down Expand Up @@ -68,6 +69,7 @@ func NewBpfLoader(config *options.BpfConfig) *BpfLoader {
}

func (l *BpfLoader) StartAdsMode() (err error) {
var ve *ebpf.VerifierError
if l.obj, err = NewBpfKmesh(l.config); err != nil {
return err
}
Expand All @@ -79,7 +81,10 @@ func (l *BpfLoader) StartAdsMode() (err error) {
}()

if err = l.obj.Load(); err != nil {
return fmt.Errorf("bpf Load failed, %s", err)
if errors.As(err, &ve) {
return fmt.Errorf("bpf Load failed: %+v", ve)
}
return fmt.Errorf("bpf Load failed: %v", err)
}

if err = l.obj.Attach(); err != nil {
Expand Down
17 changes: 14 additions & 3 deletions pkg/bpf/bpf_kmesh_l4_workload.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,11 @@
package bpf

import (
"errors"
"fmt"

"github.com/cilium/ebpf"

"kmesh.net/kmesh/daemon/options"
)

Expand Down Expand Up @@ -54,18 +57,26 @@ func newWorkloadBpf(cfg *options.BpfConfig) (*BpfKmeshWorkload, error) {

func (l *BpfLoader) StartWorkloadMode() error {
var err error
var ve *ebpf.VerifierError

if l.workloadObj, err = newWorkloadBpf(l.config); err != nil {
return err
}

defer func() {
if err != nil {
l.Stop()
}
}()

if err = l.workloadObj.Load(); err != nil {
l.Stop()
return fmt.Errorf("bpf Load failed, %s", err)
if errors.As(err, &ve) {
return fmt.Errorf("bpf Load failed: %+v", ve)
}
return fmt.Errorf("bpf Load failed: %v", err)
}

if err = l.workloadObj.Attach(); err != nil {
l.Stop()
return fmt.Errorf("bpf Attach failed, %s", err)
}
l.bpfLogLevel = l.workloadObj.SockConn.BpfLogLevel
Expand Down

0 comments on commit 304ae91

Please sign in to comment.