Skip to content

Commit

Permalink
Merge pull request #191 from manikandan300/changing_cronjob_api_v1
Browse files Browse the repository at this point in the history
changing cronjob api to v1
  • Loading branch information
kloeckner-i-devops committed Feb 20, 2024
2 parents 43931c3 + d421bb6 commit 504b8cf
Showing 1 changed file with 11 additions and 12 deletions.
23 changes: 11 additions & 12 deletions controllers/backup/cronjob.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import (
"github.com/kloeckner-i/db-operator/pkg/utils/kci"
"github.com/sirupsen/logrus"
batchv1 "k8s.io/api/batch/v1"
batchv1beta1 "k8s.io/api/batch/v1beta1"
v1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/resource"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
Expand All @@ -34,13 +33,13 @@ import (
// GCSBackupCron builds kubernetes cronjob object
// to create database backup regularly with defined schedule from dbcr
// this job will database dump and upload to google bucket storage for backup
func GCSBackupCron(conf *config.Config, dbcr *kciv1alpha1.Database, ownership []metav1.OwnerReference) (*batchv1beta1.CronJob, error) {
func GCSBackupCron(conf *config.Config, dbcr *kciv1alpha1.Database, ownership []metav1.OwnerReference) (*batchv1.CronJob, error) {
cronJobSpec, err := buildCronJobSpec(conf, dbcr)
if err != nil {
return nil, err
}

return &batchv1beta1.CronJob{
return &batchv1.CronJob{
TypeMeta: metav1.TypeMeta{
Kind: "CronJob",
APIVersion: "batch",
Expand All @@ -55,25 +54,25 @@ func GCSBackupCron(conf *config.Config, dbcr *kciv1alpha1.Database, ownership []
}, nil
}

func buildCronJobSpec(conf *config.Config, dbcr *kciv1alpha1.Database) (batchv1beta1.CronJobSpec, error) {
func buildCronJobSpec(conf *config.Config, dbcr *kciv1alpha1.Database) (batchv1.CronJobSpec, error) {
jobTemplate, err := buildJobTemplate(conf, dbcr)
if err != nil {
return batchv1beta1.CronJobSpec{}, err
return batchv1.CronJobSpec{}, err
}

return batchv1beta1.CronJobSpec{
return batchv1.CronJobSpec{
JobTemplate: jobTemplate,
Schedule: dbcr.Spec.Backup.Cron,
}, nil
}

func buildJobTemplate(conf *config.Config, dbcr *kciv1alpha1.Database) (batchv1beta1.JobTemplateSpec, error) {
func buildJobTemplate(conf *config.Config, dbcr *kciv1alpha1.Database) (batchv1.JobTemplateSpec, error) {
ActiveDeadlineSeconds := int64(conf.Backup.ActiveDeadlineSeconds)
BackoffLimit := int32(3)
instance, err := dbcr.GetInstanceRef()
if err != nil {
logrus.Errorf("can not build job template - %s", err)
return batchv1beta1.JobTemplateSpec{}, err
return batchv1.JobTemplateSpec{}, err
}

var backupContainer v1.Container
Expand All @@ -83,18 +82,18 @@ func buildJobTemplate(conf *config.Config, dbcr *kciv1alpha1.Database) (batchv1b
case "postgres":
backupContainer, err = postgresBackupContainer(conf, dbcr)
if err != nil {
return batchv1beta1.JobTemplateSpec{}, err
return batchv1.JobTemplateSpec{}, err
}
case "mysql":
backupContainer, err = mysqlBackupContainer(conf, dbcr)
if err != nil {
return batchv1beta1.JobTemplateSpec{}, err
return batchv1.JobTemplateSpec{}, err
}
default:
return batchv1beta1.JobTemplateSpec{}, errors.New("unknown engine type")
return batchv1.JobTemplateSpec{}, errors.New("unknown engine type")
}

return batchv1beta1.JobTemplateSpec{
return batchv1.JobTemplateSpec{
ObjectMeta: metav1.ObjectMeta{
Labels: kci.BaseLabelBuilder(),
},
Expand Down

0 comments on commit 504b8cf

Please sign in to comment.