Allow ssl errors #107
Open
Allow ssl errors #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Max1tors
force-pushed
the
allow-ssl-errors
branch
from
e77b0be to
481ccef
Compare
jerbob92
requested changes
Oct 25, 2024
src/platforms/android/java/com/klippa/NativeScriptHTTP/Async.java
Outdated
Show resolved
Hide resolved
jerbob92
requested changes
Oct 25, 2024
|
Thanks for your comments, I made improvements to the code now. iOS is still missing. I'll make a separate pull request for it if I get it working. But this only adds it to the Android side. |
jerbob92
requested changes
Oct 25, 2024
README.md
Outdated
| */ | ||
| allowSslErrors(true); | ||
| export declare function enableSSLValidation(): void; |
There was a problem hiding this comment.
I think it's fine to keep only 1 method, I just wanted it renamed
| InitClient(); | ||
|
|
||
| try { | ||
| TrustManagerFactory trustManagerFactory = TrustManagerFactory.getInstance(TrustManagerFactory.getDefaultAlgorithm()); |
There was a problem hiding this comment.
My intention was to do this inside InitClient while building the client, but before running client.build()
Max1tors
force-pushed
the
allow-ssl-errors
branch
from
53f2d2e to
7b8af78
Compare
|
I've now finishe iOS side of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Does not allow SSL errors or self-signed certificates
What is the new behavior?
Enables allowing ssl errors and self-signed certificates
Fixes/Implements/Closes #99.