feat(RealitioProxy): update contract for V2 #1
Conversation
|
Warning Rate limit exceeded@jaybuidl has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 35 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
WalkthroughIn the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant RealitioProxyV2
participant IRealitio
participant IRealitioArbitrator
User->>RealitioProxyV2: requestArbitration(questionID)
RealitioProxyV2->>IRealitioArbitrator: getDisputeFee(questionID)
IRealitioArbitrator-->>RealitioProxyV2: disputeFee
RealitioProxyV2->>IRealitio: notifyOfArbitrationRequest(questionID)
IRealitio-->>RealitioProxyV2: confirmation
RealitioProxyV2-->>User: Arbitration Requested
User->>RealitioProxyV2: rule(questionID, ruling)
RealitioProxyV2->>IRealitio: assignWinnerAndSubmitAnswerByArbitrator(questionID, answer, ...)
IRealitio-->>RealitioProxyV2: confirmation
RealitioProxyV2-->>User: Ruling Submitted
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- contracts/src/RealityV2.sol (1 hunks)
- contracts/src/interfaces/IRealitio.sol (1 hunks)
- contracts/src/interfaces/IRealitioArbitrator.sol (1 hunks)
Additional comments not posted (15)
contracts/src/interfaces/IRealitioArbitrator.sol (3)
21-21: LGTM!The function signature adheres to best practices.
28-28: LGTM!The function signature adheres to best practices.
32-32: LGTM!The function signature adheres to best practices.
contracts/src/interfaces/IRealitio.sol (2)
23-27: LGTM!The function signature adheres to best practices.
37-43: LGTM!The function signature adheres to best practices.
contracts/src/RealityV2.sol (10)
66-98: LGTM!The constructor initializes all parameters correctly and follows best practices.
103-104: LGTM!The function logic is correct and follows best practices.
111-122: LGTM!The function logic is correct and follows best practices.
129-135: LGTM!The function logic is correct and follows best practices.
141-143: LGTM!The function logic is correct and follows best practices.
149-170: LGTM!The function logic is correct and follows best practices.
176-188: LGTM!The function logic is correct and follows best practices.
197-210: LGTM!The function logic is correct and follows best practices.
215-220: LGTM!The function logic is correct and follows best practices.
222-226: LGTM!The error definitions are correct and follow best practices.
jaybuidl
force-pushed
the
feat/contract-update
branch
from
25bd8ab to
8e8577b
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
🔭 Outside diff range comments (1)
contracts/deploy/00-reality-v2.ts (1)
Line range hint
51-62: Update deployment arguments to match updated contract constructor.The constructor of
RealitioProxyV2has been updated to include new parameters:_governor,_realitio,_metadata, and_evidenceModule. The deployment script needs to be adjusted to provide these arguments in the correct order.Apply this diff to update the deployment script:
await deploy("RealityV2", { from: deployer, args: [ + deployer, // _governor + realitioAddress, // _realitio (define or obtain the Realitio contract address) + metadata, // _metadata (define as needed) klerosCore.address, // _arbitrator extraData, // _arbitratorExtraData + evidenceModuleAddress, // _evidenceModule (deploy or obtain EvidenceModule address) disputeTemplateRegistry.address, // _templateRegistry disputeTemplate, // _templateData disputeTemplateMappings, // _templateDataMappings - 600, // feeTimeout: 10 minutes (parameter no longer used) ], log: true, });Ensure that
realitioAddress,metadata, andevidenceModuleAddressare defined or obtained before deployment. ThefeeTimeoutparameter appears to be obsolete with the updated constructor and can be removed.
🧹 Nitpick comments (1)
contracts/src/RealityV2.sol (1)
40-42: Remove resolved TODO comment to enhance code clarity.The TODO comment on line 40 appears to have been addressed by including
templateRegistryin theArbitrationRequeststruct. To improve code readability, consider removing the TODO comment.
Summary by CodeRabbit
New Features
RealitioProxyV2contract with enhanced arbitration functionalities.IRealitioandIRealitioArbitratorto facilitate external interactions.requestArbitrationfunction for submitting arbitration requests.reportAnswerfunction for reporting answers after rulings.Improvements
Bug Fixes