-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: footer buttons not aligned properly #424
Conversation
✅ Deploy Preview for kleros-court ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job but we can do more unrelated improvements, now that you're at it, you can push it to the same PR/branch:
- the horizontal paddings have to be equal with the navbar above.
- change twitter logo for X logo (you can take it from the kleros-v2 repo assets), change all twitter links for x links. twitter logo was not fully aligned with the other icons either if u look closely
- make the footer visible in mobile, change the arrangement in mobile so that its a flex-direction: column, and make sure it looks good in mobile
2024-08-02.21-55-41.mp4
…on mobile devices
Quality Gate passedIssues Measures |
Preview
Changes
Footer.css was linted automatically
Fixes #423
PR-Codex overview
The focus of this PR is to replace the Twitter icon with a new SVG icon, update styles in
footer.css
, and improve responsiveness.Detailed summary
Twitter
icon with a new SVG infooter/index.js
footer.css
for better alignment and responsiveness