fix: footer buttons not aligned properly #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kleros-court ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kemuru
requested changes
Aug 2, 2024
There was a problem hiding this comment.
good job but we can do more unrelated improvements, now that you're at it, you can push it to the same PR/branch:
- the horizontal paddings have to be equal with the navbar above.
- change twitter logo for X logo (you can take it from the kleros-v2 repo assets), change all twitter links for x links. twitter logo was not fully aligned with the other icons either if u look closely
- make the footer visible in mobile, change the arrangement in mobile so that its a flex-direction: column, and make sure it looks good in mobile
2024-08-02.21-55-41.mp4
…on mobile devices
|
kemuru
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview
Changes
Footer.css was linted automatically
Fixes #423
PR-Codex overview
The focus of this PR is to replace the Twitter icon with a new SVG icon, update styles in
footer.css, and improve responsiveness.Detailed summary
Twittericon with a new SVG infooter/index.jsfooter.cssfor better alignment and responsiveness