Screen('DrawDots'): Only apply a margin to non-square dot types. #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only round dots get trimmed in the fragment shader, and so dot_type=4 was left with too much padding from the vertex shader.
|
Oh, stupido! Yes, that looks right, good catch, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only round dots get trimmed in the fragment shader, and so dot_type=4 was left with too much padding from the vertex shader.
Tested on Ubuntu 20.04 + AMD Pro W5500 + Octave with this script: https://gist.github.com/aforren1/31028d18da246db26bae207a009d23b0. The first row of dots is
dot_type=0, the second row isdot_type=4, and the third isdot_type=3.The first image is the old behavior with 10px dots, and the second is the new.