Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard package.json exports pattern #353

Open
wants to merge 2 commits into
base: alpha
Choose a base branch
from

Conversation

wnayes
Copy link

@wnayes wnayes commented Jan 7, 2024

This updates the alpha branch package.json to use exports to declare the different available exports. I was having a lot of trouble using the ESM code in the current alpha with how it is currently set up.

This would be considered a breaking change, however it seems like the right direction to pursue for a future major release.

The first commit implements the proposed package exports changes.

The second commit updates the repository so that test code continues to compile. This was a little more involved.

  • The package.json exports pattern is only handled in TS 4.7+, so I updated typescript to that version.
  • Webpack also seemed like it needed to be updated due to webpack#14532 which otherwise causes an error like "Error: error:0308010C:digital envelope routines::unsupported."
  • The tests don't pass, however I believe the not passing behavior is the same as on the existing alpha branch.

Just putting this out here in case there is interest in taking the change upstream. I published this as @wnayes/electron-redux if anyone is interested.

@CLAassistant
Copy link

CLAassistant commented Jan 7, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants