TH9000: Add programmable buttons to settings. #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kk7ds
reviewed
Apr 1, 2025
| @@ -807,6 +867,96 @@ def _filter(name): | |||
| int(_freqrange.rxrangehi) / 10)) | |||
| freqrange.append(rs) | |||
|
|
|||
| rs = RadioSetting( | |||
| "btn_p1", "P1 Short Press", | |||
| RadioSettingValueList( | |||
There was a problem hiding this comment.
There's a newer/better way to do this, which is RadioSettingValueMap which tolerates invalid data better than the List variant. This is okay as it is, but you might want to consider converting these to use the map method for better safety in the future.
There was a problem hiding this comment.
You did use current_index though, which is also good for safety. Just FYI is all.
|
I squashed the fix patch into the first one. In the future please just do that and update the PR. No need to keep the bad+good commits in the history forever :) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for configuring the programmable buttons on the THT TH-9000.