Fixes for kenwood live #1067
Merged
Fixes for kenwood live #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
kk7ds
commented
Jun 18, 2024
kk7ds
commented
- kenwood v71: Fix long-standing valid_bands issue
- Fix tuning step when bandplan is invalid
Somehow this driver has never had valid_bands defined?! Fixes #11386
Right now we will choose the tuning step for a new edit from the bandplan, even if that doesn't work for the frequency entered. Ironically, the most common frequency in the NA bandplan (146.520) would choose a step of 25kHz, which isn't actually aligned. Radios that really care about this (i.e. kenwood live radios) will balk at 146.52 at 25kHz, allow it at 20kHz, and allow 146.50 at 25kHz. This makes memedit use the band plan step if it is valid for the entered frequency, else fall back to the minimum-viable logic that we use when there is no bandplan step. Fixes #11391
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.