-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build backend updated to poetry core #119
base: master
Are you sure you want to change the base?
Build backend updated to poetry core #119
Conversation
Can you explain more why the issue you link to is an issue in bitshuffle? That Generally I'm interested in moving a bunch of packages to more modern build methods but in my (limited) past experience poetry is the most frustrating of them all. At the moment the current setup.py/setuptools builds mostly works fine so a high premium should be placed on changing it over. Are there tweaks to the |
Anyway @danielemichilli I'm on vacation for two weeks, but it would be good to figure out the pros and cons of this when I'm back. Otherwise Kiyo might be able to deal with it in the mean time. |
This is not necessarily an issue with bitshuflle but I think making it poetry-compatible is a good idea if it does not cause problems with the module. I was able to install bitshuffle without issues after my edits with or without poetry but I am not aware of all the building methods that are necessary to be supported. I believe this would be a quick test to run, in the meantime, enjoy your vacation!
I have looked into this but I did not find a way to do it. |
@danielemichilli @jrs65 -- looking into this issue and here are some observations.
You need Most third-party dependency resolution systems, The solution is quite simple,
|
I would recommend closing this PR in favor of #123 |
This solves issue #118 and makes the repository compatible with poetry. To do so, it updates the style of
pyproject.toml
and uses its light weight, fully compliant, self-contained package allowing PEP 517 compatible build frontends, solving the error indicated in the issue