Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H5Z_FLAG_OTPTIONAL compliant behavior when lz4 compressoin enabled #111

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on Mar 22, 2022

  1. H5Z_FLAG_OTPTIONAL compliant behavior when lz4 compressoin enabled

    When lz4 compression is enabled and the H5Z_FLAG_OPTIONAL flag is set
    compression is abborted and an error returned when the size of output
    stream exceeds the size of the input stream in bytes. This is the
    behaviour for compression filters recommended by the libhdf5
    documentation for the HZ5_FLAG_OPTIONAL.
    
    Added compiletime macros allowing fast abort in single threaded mode and
    when compiled with omp support. In the latter case it is ensured that
    no futher chunk is shuffled and compressed after abort has been
    signalled by any of the threads. The actual abort occurs as soon as all
    workers have safely cleared their queue.
    
    Missing calls to  ioc_destroy in case of error by bshuf_blocked_wrap_fun
    ========================================================================
    ioc_destroy function was only called on return when bshuf_bloced_wrap_fun
    finished successfully. In any error case just the error coded was
    returned but the ioc_pipipine was not released. In single threaded mode
    this does not have any effect as ioc_destroy is a noop which is very
    likely removed during call site optimization step. But when compiling
    with omp enabled than it is responsible that all synchonization barriers
    and locks are properly released again. Which was not the case when
    bshuf_blocked_wrap_fun aborted returning an error code.
    
    Added Compile time macros for tearing down ioc before returning error
    code.
    Bitte geben Sie eine Commit-Beschreibung für Ihre Änderungen ein. Zeilen,
    die mit '#' beginnen, werden ignoriert, und eine leere Beschreibung
    bricht den Commit ab.
    hernot committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    df16744 View commit details
    Browse the repository at this point in the history
  2. rebased to current head with zstd support

    not able to run tests cause of some errors need help figuring and fix
    hernot committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    8ab72d3 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2022

  1. Configuration menu
    Copy the full SHA
    d904f98 View commit details
    Browse the repository at this point in the history