[로또 게임] Step 2 리뷰 요청드립니다 #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deocksoo
requested changes
Jul 22, 2021
|
|
||
| public RankMap getRankResult(Lottos lottos, List<Integer> winningNumber, int bonusNumber) { | ||
| RankMap rankMap = new RankMap(Rank.class); | ||
| for (Lotto lotto : lottos.getLottos()) { |
There was a problem hiding this comment.
Lottos 일급컬렉션에서 로또를 꺼내서, 각각의 Lotto로부터 Rank를 만들어 RankMap에 넣고 있군요.
일급컬렉션을 만드신 이유를 한 번 더 고민해보시면 좋을 것 같아요. java Collection을 한 번 감싸고, 다른 이름을 붙여주기만 하면 일급컬렉션으로 생각해도 좋을까요? java Collection을 감싸는 이유는 무엇인가요?
Lottos로 감싼 collection을 되도록 밖으로 꺼내지 않고 해결할 수 있는 방법은 없나요?
|
|
||
| import java.util.EnumMap; | ||
|
|
||
| public class RankMap extends EnumMap<Rank, Integer> { |
There was a problem hiding this comment.
Java Collection을 상속받고 있군요. RankMap은 EnumMap과 무슨 차이가 있나요?
이렇게 상속 받은 이유가 무엇인가요?
| import java.util.stream.Collectors; | ||
| import java.util.stream.IntStream; | ||
|
|
||
| public class LottoMachine { |
There was a problem hiding this comment.
LottoMachine이 너무 많은 역할을 담당하고 있는 것 같아요.
기능과 역할에 맞게 객체를 조금 더 분리해보는 것은 어떤가요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EnumMap 과 초기화
-참고링크
list 여러 개 합치는 함수
commit 메시지 컨벤션
SonarLint사용법