Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kiwix desktop jammy appimage #771

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

veloman-yunkan
Copy link
Collaborator

@veloman-yunkan veloman-yunkan commented Oct 30, 2024

Fixes kiwix/kiwix-desktop#1219

Depends on kiwix/container-images#264

A working appimage was created using the updated scripts/create_kiwix-desktop_appImage.sh in a docker container build using the following Dockerfile kiwix-build_ci/jammy_builder.dockerfile introduced by kiwix/container-images#264).

@veloman-yunkan veloman-yunkan changed the title Kiwix desktop jammy appimage [WIP] Kiwix desktop jammy appimage Oct 30, 2024
@veloman-yunkan
Copy link
Collaborator Author

So we need to introduce a jammy builder. The big question is which of our CI/CD jobs should we switch to that new build platform? Should we only create the kiwix-desktop appimage under jammy or some other builds should be upgraded as well?

@kelson42
Copy link
Contributor

@veloman-yunkan Great but I don't know how/what to answer to you. We probably need to move the whole linux compilation ci/cd on jammy.

@veloman-yunkan
Copy link
Collaborator Author

@veloman-yunkan Great but I don't know how/what to answer to you. We probably need to move the whole linux compilation ci/cd on jammy.

@kelson42 Then I believe that such a transition shouldn't be done as part of this PR. Rather a separate ticket must be opened and the pros and cons of the proposed upgrade should be discussed there in a broader scope.

@kelson42
Copy link
Contributor

kelson42 commented Nov 5, 2024

@veloman-yunkan So what would be the solution for 2.4.0?

@veloman-yunkan
Copy link
Collaborator Author

@veloman-yunkan So what would be the solution for 2.4.0?

Maybe we can release only kiwix-desktop (and its appimage) from under jammy?

@kelson42
Copy link
Contributor

@veloman-yunkan So what would be the solution for 2.4.0?

Maybe we can release only kiwix-desktop (and its appimage) from under jammy?

As this stage, I believe this could be a temporary solution indeed.

@veloman-yunkan veloman-yunkan force-pushed the kiwix-desktop_jammy_appimage branch 2 times, most recently from bab1edb to 61f7d3f Compare November 25, 2024 14:12
@veloman-yunkan veloman-yunkan changed the title [WIP] Kiwix desktop jammy appimage Kiwix desktop jammy appimage Nov 25, 2024
@veloman-yunkan veloman-yunkan marked this pull request as ready for review November 25, 2024 15:02
@veloman-yunkan
Copy link
Collaborator Author

The PR is mostly ready. The most recent CI run generated an appimage built under jammy (https://tmp.kiwix.org/ci/dev_preview/kiwix-desktop_jammy_appimage/kiwix-desktop_x86_64_2024-11-25.appimage) that is devoid of the issue reported in kiwix/kiwix-desktop#1219.

The failure of the two CI runs under manylinux seems to be because of the change of the builder docker image tag from 2024-06-03 to latest.

@veloman-yunkan
Copy link
Collaborator Author

FYI, regarding the flatpak version of kiwix-desktop - it (https://tmp.kiwix.org/ci/dev_preview/kiwix-desktop_jammy_appimage/org.kiwix.desktop.2024-11-25.flatpak which was built under focal) works fine since a newer version of Qt is used in Flatpak.

@veloman-yunkan
Copy link
Collaborator Author

veloman-yunkan commented Nov 25, 2024

The failure of the two CI runs under manylinux seems to be because of the change of the builder docker image tag from 2024-06-03 to latest.

I cannot find where the manylinux version of the docker image is hosted. https://ghcr.io/kiwix/kiwix-build_ci_focal works, https://ghcr.io/kiwix/kiwix-build_ci_manylinux doesn't.

- Switched from linuxdeployqt to (linuxdeploy + linuxdeploy-plugin-qt)

- Eliminated custom creation of the AppDir & most manual copying of
  some stuff into it (trusting linuxdeploy to do everything needed
  for the correct operation of the appimage). Note, however, that
  nss/ libs are no longer bundled with the appimage (libthai.so is
  forcefully bundled via a special option to linuxdeploy).
Next we are going to have some CI/CD jobs running on jammy instead
of focal that's why the build platform for Linux jobs has to be made explicit.
Note that the tag of the kiwix-build CI builder docker image had to be
changed to latest since the jammy version doesn't have the old tag.
@kelson42
Copy link
Contributor

The PR is mostly ready. The most recent CI run generated an appimage built under jammy (https://tmp.kiwix.org/ci/dev_preview/kiwix-desktop_jammy_appimage/kiwix-desktop_x86_64_2024-11-25.appimage) that is devoid of the issue reported in kiwix/kiwix-desktop#1219.

The failure of the two CI runs under manylinux seems to be because of the change of the builder docker image tag from 2024-06-03 to latest.

Maybe installing the requests Python module? https://stackoverflow.com/questions/17309288/importerror-no-module-named-requests

@kelson42
Copy link
Contributor

The PR is mostly ready. The most recent CI run generated an appimage built under jammy (https://tmp.kiwix.org/ci/dev_preview/kiwix-desktop_jammy_appimage/kiwix-desktop_x86_64_2024-11-25.appimage) that is devoid of the issue reported in kiwix/kiwix-desktop#1219.
The failure of the two CI runs under manylinux seems to be because of the change of the builder docker image tag from 2024-06-03 to latest.

Maybe installing the requests Python module? https://stackoverflow.com/questions/17309288/importerror-no-module-named-requests

@benoit74 @rgaudin Do you have an idea why the CI fails? The packages requests seems installed properly !!? See https://github.com/kiwix/container-images/blob/main/kiwix-build_ci/manylinux_builder.dockerfile#L16

@rgaudin
Copy link
Member

rgaudin commented Nov 27, 2024

@kelson42, again, don't look at the Upload failure logs output. The problem is always in previous steps. In this one, it's in the checkout one: pip3: command not found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev appimage version is not able to play well all videos, all the time
3 participants