-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kiwix desktop jammy appimage #771
base: main
Are you sure you want to change the base?
Conversation
So we need to introduce a |
@veloman-yunkan Great but I don't know how/what to answer to you. We probably need to move the whole linux compilation ci/cd on jammy. |
@kelson42 Then I believe that such a transition shouldn't be done as part of this PR. Rather a separate ticket must be opened and the pros and cons of the proposed upgrade should be discussed there in a broader scope. |
@veloman-yunkan So what would be the solution for |
Maybe we can release only |
As this stage, I believe this could be a temporary solution indeed. |
bab1edb
to
61f7d3f
Compare
The PR is mostly ready. The most recent CI run generated an appimage built under jammy (https://tmp.kiwix.org/ci/dev_preview/kiwix-desktop_jammy_appimage/kiwix-desktop_x86_64_2024-11-25.appimage) that is devoid of the issue reported in kiwix/kiwix-desktop#1219. The failure of the two CI runs under manylinux seems to be because of the change of the builder docker image tag from |
FYI, regarding the flatpak version of kiwix-desktop - it (https://tmp.kiwix.org/ci/dev_preview/kiwix-desktop_jammy_appimage/org.kiwix.desktop.2024-11-25.flatpak which was built under focal) works fine since a newer version of Qt is used in Flatpak. |
I cannot find where the manylinux version of the docker image is hosted. https://ghcr.io/kiwix/kiwix-build_ci_focal works, https://ghcr.io/kiwix/kiwix-build_ci_manylinux doesn't. |
This reverts commit dee57f1.
- Switched from linuxdeployqt to (linuxdeploy + linuxdeploy-plugin-qt) - Eliminated custom creation of the AppDir & most manual copying of some stuff into it (trusting linuxdeploy to do everything needed for the correct operation of the appimage). Note, however, that nss/ libs are no longer bundled with the appimage (libthai.so is forcefully bundled via a special option to linuxdeploy).
Next we are going to have some CI/CD jobs running on jammy instead of focal that's why the build platform for Linux jobs has to be made explicit.
Note that the tag of the kiwix-build CI builder docker image had to be changed to latest since the jammy version doesn't have the old tag.
61f7d3f
to
d424a4e
Compare
Maybe installing the |
@benoit74 @rgaudin Do you have an idea why the CI fails? The packages |
@kelson42, again, don't look at the Upload failure logs output. The problem is always in previous steps. In this one, it's in the checkout one: |
Fixes kiwix/kiwix-desktop#1219
Depends on kiwix/container-images#264
A working appimage was created using the updated
scripts/create_kiwix-desktop_appImage.sh
in a docker container build using the following Dockerfilekiwix-build_ci/jammy_builder.dockerfile
introduced by kiwix/container-images#264).