-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use eTag for http caching #1034
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1034 +/- ##
==========================================
- Coverage 39.01% 37.98% -1.04%
==========================================
Files 119 119
Lines 6959 6969 +10
==========================================
- Hits 2715 2647 -68
- Misses 4244 4322 +78 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly OK but those wide status code ranges are unnecessary and fragile
Question about code base: Are we currently following redirects? Should we return a redirect on the catalogURL (and eventually return the content), would that work as expected? |
I did a test with this:
|
ebe929a
to
d4dbd2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good
d4dbd2f
to
585e419
Compare
Fixes: #1007