[ENH] refactor application translation base module #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bim-g
added
enhancement
bim-g
commented
Jun 25, 2024
| */ | ||
| function tra(string $message, $value = null): string | ||
| { | ||
| $i18n = new \Wepesi\Core\i18n(\Wepesi\Core\Session::get('lang')); |
There was a problem hiding this comment.
This approach of loading the default language from session on not the right way. we should have another method to check the default language from the .env file, and then, set it up on the session.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The translation module s verry poor, a nice default structure and setup by default, that waiting to use to start his own process without knowing how to deal with.