Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fi): add unseal_by_receiver_only 40326 #38

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

kampiliira
Copy link
Contributor

No description provided.

@kampiliira kampiliira requested a review from a team as a code owner February 14, 2025 14:45
@kampiliira kampiliira requested a review from minkkilj February 14, 2025 14:45
@k-patrik
Copy link
Contributor

k-patrik commented Feb 17, 2025

Hey there! Fine by me but I wonder if it isn't time to split this repo? Since the business logic has converged that much; we don't have any seal/unseal requirement in Swedish inboxes as far as I know.

Copy link
Contributor

@k-patrik k-patrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblocking

@kampiliira
Copy link
Contributor Author

Thanks @k-patrik. There are at least two repos that shouldn't be split, in my opinion: kivra-api-errors and event_schemas. This is because ours apps still share code heavily with Sweden, so it will be wise to keep the error codes and certain schemas aligned. For example, if the kivra-api-errors repo were to diverge and Sweden decides to take 40326 to mean a different error, it will be very difficult for the apps to keep track the differences. It will be best for the same error code to mean the same thing, everywhere, across different markets.

@kampiliira kampiliira merged commit 1d55a47 into main Feb 20, 2025
2 checks passed
@kampiliira kampiliira deleted the yy-not-intended-receiver branch February 20, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants