fix: the "check_slab() succeeded!" does not in lab5-lab8's grade.sh,… #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…but in answer's grade.sh, that will result in not getting full score.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lab5-lab8 answer的grade.sh里面有关于slab的check, 'check_slab() succeeded!'，而对应的代码里面是cprintf("check_slab() success\n");，输出'check_slab() success'，这样会导致make grade的时候不能得满分。
在练习的代码里面即labcodes里面的grade.sh是没有'check_slab() succeeded!'这样的check，因而考虑是不是可以把labcodes_answer里面对应的删除。