Remove all instances of floating promises in processor #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdulrhmnGhanem
approved these changes
Nov 30, 2022
AbdulrhmnGhanem
requested changes
Nov 30, 2022
This comment was marked as outdated.
This comment was marked as outdated.
kasbah
force-pushed
the
ke/processor-remove-floating-promises
branch
from
022385e
to
f476998
Compare
AbdulrhmnGhanem
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like the style I adopted of just "floating" all the
job.updateProgressmakes things less predictable without much gain.