Skip to content

Add backend for DSVGO banner settings#29

Merged
sneridagh merged 12 commits into
mainfrom
dsgvo-settings
Jun 11, 2026
Merged

Add backend for DSVGO banner settings#29
sneridagh merged 12 commits into
mainfrom
dsgvo-settings

Conversation

@davisagli

@davisagli davisagli commented May 11, 2026

Copy link
Copy Markdown
Member

https://gitlab.kitconcept.io/kitconcept/distribution-kitconcept-website/-/work_items/46

This adds a control panel for configuring settings for the @kitconcept/volto-dsgvo-banner add-on. This PR is a draft because the frontend add-on still needs to be updated.

What's included

  • registry settings (with same defaults as the existing Volto settings in kitconcept/volto-dsgvo-banner)
  • dsgvo-settings control panel (for REST API / Volto)
  • ISiteEndpointExpander to include the value of these settings in the @site endpoint
  • Upgrade step
  • Functional tests
  • Fix locales (kitconcept.website domain rather than kitconcept.site, add missing DE translation)
  • Fix default language setting (remove it from the default profile so it doesn't get overwritten during an upgrade)

To do

  • Use a new release of volto-dsgvo-banner
  • Docs (there's no infrastructure for this in the website distribution yet))

Screenshot

Screenshot 2026-05-11 at 2 11 03 PM

@davisagli davisagli requested review from ericof and sneridagh May 11, 2026 21:05
@Tishasoumya-02

Copy link
Copy Markdown
Contributor

PR in dsgvo addon: kitconcept/volto-dsgvo-banner#55

@sneridagh

Copy link
Copy Markdown
Member

@Tishasoumya-02 merged! Please continue with it.

@davisagli we don't add for now the ID of the tracker? I guess it's the next thing that we will need to customize.

@Tishasoumya-02

Tishasoumya-02 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Sorry! got confused with the other frontend PR for dsgvo
that it was complete so I closed this. But this was for backend stuff

@Tishasoumya-02

Copy link
Copy Markdown
Contributor

Screenshots:

With the following control panel settings:

Screenshot 2026-06-05 at 3 23 46 PM Screenshot 2026-06-05 at 3 23 21 PM Screenshot 2026-06-05 at 3 23 17 PM

When show GDPR false:

Screenshot 2026-06-05 at 3 24 06 PM

@Tishasoumya-02

Copy link
Copy Markdown
Contributor

@sneridagh , the dsgvo version in VLT is already updated in this PR kitconcept/volto-light-theme#833 and is in main branch now, it just needs a release then I'll update VLT here too .

@Tishasoumya-02 Tishasoumya-02 marked this pull request as ready for review June 10, 2026 10:19
@sneridagh

Copy link
Copy Markdown
Member

@Tishasoumya-02 Release 8.0.0a29 was released and added in the website dist. Please continue rolling this up! Next is merge I guess! Could you please confirm that it works well and report back? Then we can merge.

@Tishasoumya-02

Tishasoumya-02 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

@sneridagh yes, updated with main and works well , added screenshots above. We can merge this now

@sneridagh sneridagh merged commit 661b265 into main Jun 11, 2026
58 of 60 checks passed
sneridagh added a commit that referenced this pull request Jun 11, 2026
@sneridagh

Copy link
Copy Markdown
Member

@Tishasoumya-02 @jnptk please let's continue the things to be done in the ticket in: #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants