Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to local endpoints #53

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Adding support to local endpoints #53

wants to merge 21 commits into from

Conversation

nicxlau
Copy link

@nicxlau nicxlau commented Jul 26, 2024

When using local endpoints like localhost or the ID of a docker container are passed, https is always appended to the endpoint.

Example of how it is currently happening:

$connection = new Connection(['endpoint' => 'example-container']); // https://example-container
$connection = new Connection(['endpoint' => 'example-container:8000']); // https://example-container:8000

This PR prevent it.

@kitar
Copy link
Owner

kitar commented Jul 31, 2024

Thank you for the suggestion, @nicxlau ! Could you please try to see if this issue is resolved with #41?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants