Refactor Loop class to use a LoopTools singleton for tool management for Octane compatibility #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26
There is an Octane compatibility issue where registered tools don't persist between request cycles due to
scoped
instance recreation of theLoop
class.The proposed fix is storing the tools in a singleton
LoopTools
. Another option is making theLoop
class asingleton
but keep in mind the instance would be shared between users in Octane.Current Behavior
The Issue
boot()
which only run once when worker startsCurrent Application Workaround