Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix click events | remove preventDefault in bodyDown method #131

Open
wants to merge 1 commit into
base: vue3
Choose a base branch
from
Open

Fix click events | remove preventDefault in bodyDown method #131

wants to merge 1 commit into from

Conversation

donaldma
Copy link

fixes #67, fixes #73

@donaldma
Copy link
Author

@kirillmurashov or we could make preventDefault optional by a flag

@erhanfirat
Copy link

Will be this commit merged and published new version?
I had same bug and it is an emergency for me.

@donaldma
Copy link
Author

donaldma commented Dec 1, 2021

if the reviewers ever get to it

@whyym
Copy link

whyym commented Mar 31, 2022

This does not seem necessary，We just do:
@clicked="onClicked"
onClicked(ev) {
ev.preventDefault = undefined
},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@donaldma @erhanfirat @whyym