-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Semio] Scratch Update/Fixes #488
Conversation
- Update Dockerfile to install additional dependencies - Modify package.json to include a new build-deps script - Add scratch submodule
There appears to be some issue when building:
The fix seems to be to go into |
It seems the issue here: |
Last issue that I've seen is that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also noticed that the work for the LMS PR is included in this one. It may need to be removed or the LMS PR will need to merge first.
Thanks for the feedback. I've updated the readme instructions to reflect the need to run git submodules init twice, and pushed a fix for the change VARIABLE by NUMBER bug. You are correct, Show Variable does run on every step, if you want it to run once you should show and the stop show right after. If this is not the desired behavior let me know, I work on alternatives. |
As for the LMS work, I had intended that to merge first as it seemed like a simpler PR - but if this is done first I can pull those commits out to make this a clean PR. |
I think you are correct that the showing of a variable after each command is the correct behavior since the hide variable command exists. I don't see any other issues though so I think this PR is ready to merge! |
This is an updated PR for scratch support that is ready to be merged onto the existing master branch. To fix the issue referenced in #461 (comment) use this version of itch: https://github.com/chrismbirmingham/itch#34