Repository navigation
Test the values of geometric_cooling - #24
Merged
Merged
Conversation
c(0) = 1, c(n/2) = sqrt(frac), c(n) = frac for the default n and n = 20; frac = 1 gives a constant schedule; frac = 0 is refused. Five of the seven checks fail under the old formula log(frac/n).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #24 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 28 28
Lines 871 871
=========================================
Hits 871 871 🚀 New features to boost your workflow:
|
kingaa
added a commit
that referenced
this pull request
Oct 4, 2026
Test the values of geometric_cooling
kingaa
added a commit
that referenced
this pull request
Oct 4, 2026
Test the values of geometric_cooling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test the values of
geometric_coolingThanks for fixing
geometric_coolingin v0.12.1. This adds a test of theschedule's values, so the bug cannot return unnoticed (the suite used
geometric_coolingbut never checked what it returns):nand forn = 20;frac = 1gives a constant schedule;frac = 0is refused.With the old formula
log(frac/n), 5 of the 7 checks fail; on currentdevelall 7 pass.