Add auth server error handling

[DaveOrDead]

Explain your changes

Add callback for handling auth errors returned from the serve

Checklist

• I have read the “Pull requests” section in the contributing guidelines.
• I agree to the terms within the code of conduct.

🛟 If you need help, consider asking for advice over in the Kinde community.

[coderabbitai]

Warning

Rate limit exceeded

@DanielRivers has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 20 minutes and 44 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 6e12671 and fbd0f1a.

Walkthrough

The recent updates introduce an on_error_callback parameter to the createKindeClient function, enhance error handling in handleRedirectToApp, and set a default value for app_state.kindeOriginUrl in redirectToKinde. Additionally, the ErrorProps type has been added, and certain type definitions in src/types.ts have been updated to use Record<string, unknown> instead of object.

Changes

File	Change Summary
src/createKindeClient.ts	Added on_error_callback parameter, enhanced error handling in handleRedirectToApp, and set default value for app_state.kindeOriginUrl in redirectToKinde.
src/types.ts	Added ErrorProps type and updated KindeClientOptions and OrgOptions types to use Record<string, unknown> instead of object. Updated on_redirect_callback to take appState as Record<string, unknown>.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 560ffd3 and 6e12671.

Files selected for processing (2)

• src/createKindeClient.ts (6 hunks)
• src/types.ts (2 hunks)

Additional comments not posted (6)

src/types.ts (3)

18-23: The ErrorProps type definition is comprehensive and aligns well with the requirements for detailed error handling.

---

32-36: The updates to KindeClientOptions, including the addition of on_error_callback and the update to on_redirect_callback, enhance error handling capabilities and type safety.

---

93-93: The use of Record<string, unknown> for app_state in both OrgOptions and AuthOptions is a good practice for ensuring type safety and flexibility.

Also applies to: 98-98

src/createKindeClient.ts (3)

53-53: The addition of on_error_callback in createKindeClient enhances the client's ability to handle errors more gracefully.

---

284-302: The enhanced error handling in handleRedirectToApp is robust, correctly capturing and responding to errors via the on_error_callback.

---

345-355: Setting a default value for app_state.kindeOriginUrl in redirectToKinde is a prudent fallback mechanism, ensuring a consistent user experience in case of missing configuration.