Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wrong implementaion of parsing values #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix wrong implementaion of parsing values #4

wants to merge 1 commit into from

Conversation

kylezh
Copy link

@kylezh kylezh commented Mar 2, 2015

The old implementaion didn't follow
https://collectd.org/wiki/index.php/Binary_protocol

This patch fixes it.

Signed-off-by: Kai Zhang [email protected]

@kylezh
fix wrong implementaion of parsing values
0ded8d5 
The old implementaion didn't follow
https://collectd.org/wiki/index.php/Binary_protocol

This patch fixes it.

Signed-off-by: Kai Zhang <[email protected]>
@kimor79
Copy link
Owner

kimor79 commented Mar 4, 2015

Thanks. I'll test this out

@kimor79
Copy link
Owner

kimor79 commented Mar 7, 2015

The tests aren't passing with this change:

$ go test github.com/kimor79/gollectd
--- FAIL: TestPackets (0.00 seconds)
    gollectd_test.go:144: i = 0: Unknown value type
    gollectd_test.go:144: i = 2: Unknown value type
    gollectd_test.go:144: i = 3: Unknown value type
FAIL
FAIL    github.com/kimor79/gollectd 0.007s

@kylezh
Copy link
Author

kylezh commented Mar 7, 2015

I have noticed this too. This is strange.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylezh @kimor79