Fix ios 16 #1276

BrunoMazzo · 2023-02-19T05:45:35Z

Fix for iOS 16.

Adding the pickerView into the inputView of a textfield is handle different than the other iOS versions. On iOS 16, it is part of the property _fallbackView from _UIRemoteKeyboardPlaceholderView, but it is not part of the UI hierarchy (I don't know why). So in the parts that checked for elements, I added another validation for the _UIRemoteKeyboardPlaceholderView
UIDatePicker is not a subclass of UIPickerView. And it has doesn't has an UIPickerView as subview. The hierarchy is UIDatePicker -> _UIDatePickerView -> ... -> UIPickerColumnView ... But it has an _UIPickerView property that works if used.
[[UIDevice currentDevice] setValue:@(orientation) forKey:@"orientation"] doesn't work anymore. We need to use requestGeometryUpdateWithPreferences from UIWindowScene.

I'm not 100% familiar with the code, so I may be missing some context, so please let me know if there is anything I should fix.

justinseanmartin

Thank you so much for your contribution! 2 minor improvement requests and we should remove the commits that are also included in #1275. This is great!

Does this get the full KIF integration test suite passing on iOS 16 devices? If so, it would be great to get CI validating that. If not, maybe we should start working towards that and explicitly bailing out for the specific tests that we know are broken on iOS 16.

justinseanmartin · 2023-02-21T20:19:05Z

Sources/KIF/Additions/NSError-KIFAdditions.h

@@ -13,4 +13,6 @@
 + (instancetype)KIFErrorWithUnderlyingError:(NSError *)underlyingError format:(NSString *)format, ... NS_FORMAT_FUNCTION(2,3);
 + (instancetype)KIFErrorWithFormat:(NSString *)format, ... NS_FORMAT_FUNCTION(1,2);

+ (instancetype)KIFErrorFromException:(NSException *)exception;


I think this got pulled over from the other PR. Worth reverting here, as it seems unused in this context.

justinseanmartin · 2023-02-21T20:23:36Z

Sources/KIF/Additions/UIView-KIFAdditions.m

@@ -374,12 +382,25 @@ - (NSArray *)subviewsWithClassNamePrefix:(NSString *)prefix;
        if ([NSStringFromClass([view class]) hasPrefix:prefix]) {
            [result addObject:view];
        }
+
+        if([NSStringFromClass([view class]) isEqualToString:@"_UIRemoteKeyboardPlaceholderView"]) {


Rather than duplicating this logic, it'd be cleaner to add a subviewsWithPlaceholderFallbackView method that can be used in place of self.subviews in the 4 places we're iterating over self.subviews in this file.

justinseanmartin · 2023-02-21T20:25:00Z

Sources/KIF/Classes/KIFSystemTestActor.m

+
+            UIWindowSceneGeometryPreferencesIOS* preferences = [[UIWindowSceneGeometryPreferencesIOS alloc]initWithInterfaceOrientations:orientationMask];
+            [windowScene requestGeometryUpdateWithPreferences:preferences errorHandler:^(NSError * _Nonnull error) {
+                NSLog(@"error: %@", error);


Does this happen in a expected case? If not, makes sense to emit an error and fail the test.

justinseanmartin · 2023-02-21T20:26:06Z

Sources/KIF/Classes/KIFUIViewTestActor.h

@@ -137,33 +137,44 @@ extern NSString *const inputFieldTestString;
 @abstract Tap a view matching the tester's search predicate.
 @discussion The tester will evaluate the accessibility hierarchy against it's search predicate and perform a tap on the first match.
 */
- (void)tap;
+- (void)tap CF_SWIFT_UNAVAILABLE_FROM_ASYNC("use async version");


This should be reverted and decoupled from then changes in this PR I believe.

BrunoMazzo · 2023-02-21T21:12:40Z

Thanks for the feedback. I will work on it and push the changes probably in the weekend.

This fix the full suite of tests. I will remove the changes for the async stuff that I forgot (I starting work in the same branch and forgot to clean up), add the CI validation, and do the other changes.

justinseanmartin · 2023-02-22T06:42:57Z

That's great to hear! It is probably worth bumping the CI config to validate that we don't regress it. That's definitely not a blocker for landing these changes though.

justinseanmartin

Tour contributions are very much appreciated! If we can get CI green, then we should be good to go.

justinseanmartin · 2023-02-23T10:11:15Z

.github/workflows/build.yml

-
-    steps:
+          - { xcode_version: '14.1', simulator: 'name=iPad Pro (12.9-inch) (5th generation),OS=16.1' }
+    steps: &build_steps


Bummer... I liked the cleanup with the anchor, but GitHub doesn't like it:

The workflow is not valid. .github/workflows/build.yml: Anchors are not currently supported. Remove the anchor 'build_steps'

My bad. I will fix it and push it right now!

dostrander · 2023-02-23T13:05:24Z

@BrunoMazzo thanks 🎉 for finding this! So this allows you to use pickers and keyboads in iOS 16??

I was under the impression this was out of process from my debugging in this so was expecting a larger reverse engineering effort to be able to call what XCUITest calls. But if that's not that case that's amazing. Thank you SOOO much for digging into this!

dostrander · 2023-02-23T13:06:21Z

If you need some help getting it to run on iOS 16 feel free to use anything from here: #1268

I added this a while ago but since the tests weren't passing it didn't make sense to merge

justinseanmartin · 2023-02-23T19:39:43Z

I'm rerunning the failed jobs to see if the results are consistent or not. I think at this point, supporting only Xcode 13.4.1 (Monterey) & 14.2 (Ventura) seems reasonable to me. Maybe we could do one iPad + iPhone device on each platform? Not changing the device type will help eliminate some variable that might lead other test failures related to screen dimensions and whatnot. WDYT? Just trying to limit how many things we need to chase down here to get this landed.

justinseanmartin · 2023-02-23T19:41:35Z

It looks like we might need some availability checking for the behavior to be backwards compatible with the iOS 15 (Xcode 13) SDK:

❌  /Users/runner/work/KIF/KIF/Sources/KIF/Classes/KIFSystemTestActor.m:98:26: no visible @interface for 'UIWindowScene' declares the selector 'requestGeometryUpdateWithPreferences:errorHandler:'

BrunoMazzo · 2023-02-25T09:26:55Z

I added a check to compile on other versions of Xcode and changed the CI to run on iPhone SE and iPad Pro, Xcode 13 and 14.

justinseanmartin

Once CI is green, we should be good to go with this.

justinseanmartin · 2023-02-25T23:14:29Z

.github/workflows/build.yml

-
-
+          - { xcode_version: '14.1', simulator: 'name=iPad Pro (12.9-inch) (5th generation),OS=16.1' }
+          - { xcode_version: '14.1', simulator: 'name=iPhone SE (3nd generation),OS=16.1' }


Meant for this to be 2nd instead of the 3nd?

justinseanmartin reviewed Feb 21, 2023

View reviewed changes

BrunoMazzo added 2 commits February 22, 2023 20:22

Fix iOS 16 bugs

11d2933

Add error if device fails to rotate

b912934

BrunoMazzo force-pushed the fix-ios-16 branch from 098141f to b912934 Compare February 22, 2023 09:42

BrunoMazzo added 2 commits February 22, 2023 21:21

Refactor iOS16 Keyboard Fallback View logic

2c8aaea

Add iOS 16 CI tests

719c9cd

BrunoMazzo requested a review from justinseanmartin February 22, 2023 10:37

justinseanmartin reviewed Feb 23, 2023

View reviewed changes

Fix github yml

ee05496

BrunoMazzo added 3 commits February 25, 2023 20:11

Add conditional to remove iOS 16 from old Xcodes

13ccb56

Update CI to test on iPhone SE and iPad pro, Xcode 13 and 14

708ab87

Change iOS check to use __IPHONE_16_0 for better readbility

5f643d6

justinseanmartin approved these changes Feb 25, 2023

View reviewed changes

Use iPhone SE 2nd generation for tests

7393c3f

justinseanmartin merged commit 3d0daa5 into kif-framework:master Feb 26, 2023

dostrander mentioned this pull request Mar 21, 2023

Update KIF to 3.8.8 #1277

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix ios 16 #1276

Fix ios 16 #1276

BrunoMazzo commented Feb 19, 2023

justinseanmartin left a comment

justinseanmartin Feb 21, 2023

justinseanmartin Feb 21, 2023

justinseanmartin Feb 21, 2023

justinseanmartin Feb 21, 2023

BrunoMazzo commented Feb 21, 2023

justinseanmartin commented Feb 22, 2023

justinseanmartin left a comment

justinseanmartin Feb 23, 2023

BrunoMazzo Feb 23, 2023

dostrander commented Feb 23, 2023

dostrander commented Feb 23, 2023

justinseanmartin commented Feb 23, 2023

justinseanmartin commented Feb 23, 2023

BrunoMazzo commented Feb 25, 2023

justinseanmartin left a comment

justinseanmartin Feb 25, 2023



		- { xcode_version: '14.1', simulator: 'name=iPad Pro (12.9-inch) (5th generation),OS=16.1' }
		- { xcode_version: '14.1', simulator: 'name=iPhone SE (3nd generation),OS=16.1' }

Fix ios 16 #1276

Fix ios 16 #1276

Conversation

BrunoMazzo commented Feb 19, 2023

justinseanmartin left a comment

Choose a reason for hiding this comment

justinseanmartin Feb 21, 2023

Choose a reason for hiding this comment

justinseanmartin Feb 21, 2023

Choose a reason for hiding this comment

justinseanmartin Feb 21, 2023

Choose a reason for hiding this comment

justinseanmartin Feb 21, 2023

Choose a reason for hiding this comment

BrunoMazzo commented Feb 21, 2023

justinseanmartin commented Feb 22, 2023

justinseanmartin left a comment

Choose a reason for hiding this comment

justinseanmartin Feb 23, 2023

Choose a reason for hiding this comment

BrunoMazzo Feb 23, 2023

Choose a reason for hiding this comment

dostrander commented Feb 23, 2023

dostrander commented Feb 23, 2023

justinseanmartin commented Feb 23, 2023

justinseanmartin commented Feb 23, 2023

BrunoMazzo commented Feb 25, 2023

justinseanmartin left a comment

Choose a reason for hiding this comment

justinseanmartin Feb 25, 2023

Choose a reason for hiding this comment