[MBL-1958] Use New PLOT Disclaimer Copy On Project Fragment #2237
+193
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottkicks
changed the title
scottkicks
changed the title
… into scott/mbl-1958
amy-at-kickstarter
approved these changes
Jan 9, 2025
jovaniks
requested changes
Jan 10, 2025
| @@ -123,7 +123,7 @@ public final class PledgePaymentPlansOptionViewModel: | |||
|
|
|||
| self.ineligibleBadgeText = configData | |||
| .filterWhenLatestFrom(ineligible, satisfies: { $0 == true }) | |||
| .map { getIneligibleBadgeText(with: $0.project, thresholdAmount: $0.thresholdAmount) } | |||
There was a problem hiding this comment.
Since thresholdAmount will no longer be used, should we remove all references to it? Also, what about PledgePaymentPlansAndSelectionData.thresholdAmount? It might be a good idea to clean those up if they're not needed anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Exposes a new
pledgeOverTimeMinimumExplanationproperty on the Project fragment and implements it.The threshold should be $125
🤔 Why
To keep this string dynamic in case the plot eligibility threshold changes in the future, payments added it for us on the Project fragment.
🛠 How
👀 See
✅ Acceptance criteria