(feature) --deployment-id option to add string suffix to the release directory name
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katjacresanti
changed the title
--deployment-id option to add a string suffix to the release directory--deployment-id option to add string suffix to the release directory name
amancevice
reviewed
Sep 6, 2024
lib/egads/command/release.rb
Outdated
| @@ -74,4 +77,4 @@ def atomic_symlink(src, dest) | |||
| File.rename(tmp, dest) | |||
| end | |||
| end | |||
| end | |||
| end | |||
amancevice
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a flag,
--deployment-id, which the user can optionally pass a string to. This (unique) string will be appended to the name of the release directory.This is technically a feature, but it also fixes a bug where force-redeploying over the current SHA causes unicorn to error by creating unique directory names.