Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

be able to configure server liveness/readiness/startup probe #847

Merged
merged 3 commits into from
Nov 14, 2024
Merged

be able to configure server liveness/readiness/startup probe #847

merged 3 commits into from
Nov 14, 2024

Conversation

jmazzitelli
Copy link
Contributor

@jmazzitelli jmazzitelli self-assigned this Nov 13, 2024
@jmazzitelli jmazzitelli mentioned this pull request Nov 13, 2024
Closed
@jmazzitelli
Copy link
Contributor Author

jmazzitelli commented Nov 13, 2024 •
edited
Loading

to test via molecule:

Have minikube with Istio installed. Push the dev images, then run the test:

hack/k8s-minikube.sh start && hack/k8s-minikube.sh istio

make CLUSTER_TYPE=minikube build build-ui cluster-push

hack/run-molecule-tests.sh --client-exe "$(which kubectl)" -dorp podman -hcrp false --cluster-type minikube -udi true -at "config-values-test"

You should see success:

=====================
=== TEST RESULTS: ===
=====================

                      config-values-test... success [2m 39s]

@jmazzitelli jmazzitelli marked this pull request as ready for review November 13, 2024 21:01
@jshaughn jshaughn added the test: molecule Molecule test infrastructure and tests themselves label Nov 14, 2024
@jshaughn jshaughn self-requested a review November 14, 2024 02:31
jshaughn
jshaughn approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the test instructions: workee!

@jmazzitelli jmazzitelli merged commit 66b36a9 into kiali:master Nov 14, 2024
1 check passed
@jmazzitelli jmazzitelli deleted the config-probe branch November 14, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jshaughn jshaughn jshaughn approved these changes

Assignees

@jmazzitelli jmazzitelli

Labels
test: molecule Molecule test infrastructure and tests themselves
Projects
Kiali Sprint 24-16 | Kiali v2.3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjustable readiness and liveness probes delay
2 participants
@jmazzitelli @jshaughn